Last Comment Bug 725488 - in Junk Settings, disable junk target folder pickers based on the radio selector (Junk on/Other), similarly to pickers on Copies & Folders
: in Junk Settings, disable junk target folder pickers based on the radio selec...
Status: RESOLVED FIXED
: polish, ux-consistency
Product: MailNews Core
Classification: Components
Component: Account Manager (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 18.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 728681 729147 793599
  Show dependency treegraph
 
Reported: 2012-02-08 14:58 PST by :aceman
Modified: 2012-10-08 11:04 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (10.03 KB, patch)
2012-09-23 14:50 PDT, :aceman
mconley: review+
bwinton: ui‑review+
Details | Diff | Review
patch v2 (10.73 KB, patch)
2012-09-26 14:12 PDT, :aceman
iann_bugzilla: review+
Details | Diff | Review

Description :aceman 2012-02-08 14:58:01 PST
In the Junk settings pane of Account manager, the folders for moving of junk mails are only disabled when the moving of junk is disabled with the checkbox.
The individual folder pickers (Junk on <thisaccount> and Other ) could be disabled depending on the radio button selecting them.
As it is done in Copies & Folders (Sent, Archive, Drafts, Templates target groups).
Comment 1 :aceman 2012-09-23 14:50:42 PDT
Created attachment 663848 [details] [diff] [review]
patch
Comment 2 Blake Winton (:bwinton) (:☕️) 2012-09-24 09:12:32 PDT
Comment on attachment 663848 [details] [diff] [review]
patch

Yep, this seems nicer, too.  ui-r=me!

Thanks,
Blake.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2012-09-26 13:58:09 PDT
Comment on attachment 663848 [details] [diff] [review]
patch

Review of attachment 663848 [details] [diff] [review]:
-----------------------------------------------------------------

Just one comment about the documentation.  Other than that, I think I'm OK with this.

Thanks aceman!

::: mailnews/base/prefs/content/am-junk.js
@@ +206,5 @@
> +  updateJunkRetention();
> +}
> +
> +/**
> + * Enable/disable the folder picker for the selected radio item.

I think this comment is misleading - it makes me think that I can use this function to enable or disable the folder picker by passing some arguments.

In actuality, it's just syncing the state of some items with some other items.

@@ +215,5 @@
> +}
> +
> +/**
> + * Enable/disable the junk deletion interval.
> + */

Same as above.
Comment 4 :aceman 2012-09-26 14:12:50 PDT
Created attachment 665127 [details] [diff] [review]
patch v2

Thanks, done.
Comment 5 Mark Banner (:standard8) 2012-10-08 11:04:10 PDT
Checked in: https://hg.mozilla.org/comm-central/rev/9c71bacbfe87

Note You need to log in before you can comment on or make changes to this bug.