in Junk Settings, disable junk target folder pickers based on the radio selector (Junk on/Other), similarly to pickers on Copies & Folders

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Account Manager
--
minor
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 2 bugs, {polish, ux-consistency})

Trunk
Thunderbird 18.0
polish, ux-consistency
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.73 KB, patch
Ian Neal
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
In the Junk settings pane of Account manager, the folders for moving of junk mails are only disabled when the moving of junk is disabled with the checkbox.
The individual folder pickers (Junk on <thisaccount> and Other ) could be disabled depending on the radio button selecting them.
As it is done in Copies & Folders (Sent, Archive, Drafts, Templates target groups).
(Assignee)

Updated

6 years ago
Summary: disable junk target folder pickers based on the radio selector, similarly to pickers on Copies & Folders → in Junk Settings, disable junk target folder pickers based on the radio selector (Junk on/Other), similarly to pickers on Copies & Folders
(Assignee)

Updated

6 years ago
Blocks: 729147
(Assignee)

Comment 1

5 years ago
Created attachment 663848 [details] [diff] [review]
patch
Attachment #663848 - Flags: ui-review?(bwinton)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Keywords: polish
(Assignee)

Updated

5 years ago
Blocks: 728681
(Assignee)

Updated

5 years ago
Blocks: 793599
Comment on attachment 663848 [details] [diff] [review]
patch

Yep, this seems nicer, too.  ui-r=me!

Thanks,
Blake.
Attachment #663848 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Attachment #663848 - Flags: review?(mconley)
Comment on attachment 663848 [details] [diff] [review]
patch

Review of attachment 663848 [details] [diff] [review]:
-----------------------------------------------------------------

Just one comment about the documentation.  Other than that, I think I'm OK with this.

Thanks aceman!

::: mailnews/base/prefs/content/am-junk.js
@@ +206,5 @@
> +  updateJunkRetention();
> +}
> +
> +/**
> + * Enable/disable the folder picker for the selected radio item.

I think this comment is misleading - it makes me think that I can use this function to enable or disable the folder picker by passing some arguments.

In actuality, it's just syncing the state of some items with some other items.

@@ +215,5 @@
> +}
> +
> +/**
> + * Enable/disable the junk deletion interval.
> + */

Same as above.
Attachment #663848 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 665127 [details] [diff] [review]
patch v2

Thanks, done.
Attachment #663848 - Attachment is obsolete: true
Attachment #665127 - Flags: review?(iann_bugzilla)

Updated

5 years ago
Attachment #665127 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in: https://hg.mozilla.org/comm-central/rev/9c71bacbfe87
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.