convert mailnews/base/prefs/content/am-junk.js to Services.jsm

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Account Manager
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 2 bugs)

Trunk
Thunderbird 19.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

7.23 KB, patch
Ian Neal
: review+
mconley
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
var fileLocator = Components.classes["@mozilla.org/file/directory_service;1"].getService(Components.interfaces.nsIProperties);

  gPrefBranch = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService)
(This can be removed altogether as it is not used after bug 725488.)
(Assignee)

Comment 1

5 years ago
Also fix the header to:
/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*-
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
(Assignee)

Comment 2

5 years ago
Created attachment 669256 [details] [diff] [review]
patch
Attachment #669256 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #669256 - Flags: review?(mconley)
Comment on attachment 669256 [details] [diff] [review]
patch

Review of attachment 669256 [details] [diff] [review]:
-----------------------------------------------------------------

Great cleanup, aceman!

::: mailnews/base/prefs/content/am-junk.js
@@ +193,5 @@
>  function updateJunkTargetsAndRetention() {
>    onCheckItem("server.moveTargetMode", ["server.moveOnSpam"]);
>    updateJunkTargets();
>    onCheckItem("server.purgeSpam", ["server.moveOnSpam"]);
> +  document.getElementById("purgeLabel").disabled =

Why was this moved? If there wasn't a good reason, put it back please. :)

@@ +291,4 @@
>  
>    while (entries.hasMoreElements())
>    {
> +    let entry = entries.nextFile;

Nice cleanup in here.
Attachment #669256 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Mike Conley (:mconley) from comment #3)
> ::: mailnews/base/prefs/content/am-junk.js
> @@ +193,5 @@
> >  function updateJunkTargetsAndRetention() {
> >    onCheckItem("server.moveTargetMode", ["server.moveOnSpam"]);
> >    updateJunkTargets();
> >    onCheckItem("server.purgeSpam", ["server.moveOnSpam"]);
> > +  document.getElementById("purgeLabel").disabled =
> 
> Why was this moved? If there wasn't a good reason, put it back please. :)

This is intentional and just fixes a minor problem with patch from bug 725488.

Updated

5 years ago
Attachment #669256 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/373ae165b4ce
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.