Closed
Bug 793599
Opened 12 years ago
Closed 12 years ago
convert mailnews/base/prefs/content/am-junk.js to Services.jsm
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: aceman, Assigned: aceman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
7.23 KB,
patch
|
iannbugzilla
:
review+
mconley
:
review+
|
Details | Diff | Splinter Review |
var fileLocator = Components.classes["@mozilla.org/file/directory_service;1"].getService(Components.interfaces.nsIProperties); gPrefBranch = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService) (This can be removed altogether as it is not used after bug 725488.)
Also fix the header to: /* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
Attachment #669256 -
Flags: review?(iann_bugzilla)
Attachment #669256 -
Flags: review?(mconley)
Comment 3•12 years ago
|
||
Comment on attachment 669256 [details] [diff] [review] patch Review of attachment 669256 [details] [diff] [review]: ----------------------------------------------------------------- Great cleanup, aceman! ::: mailnews/base/prefs/content/am-junk.js @@ +193,5 @@ > function updateJunkTargetsAndRetention() { > onCheckItem("server.moveTargetMode", ["server.moveOnSpam"]); > updateJunkTargets(); > onCheckItem("server.purgeSpam", ["server.moveOnSpam"]); > + document.getElementById("purgeLabel").disabled = Why was this moved? If there wasn't a good reason, put it back please. :) @@ +291,4 @@ > > while (entries.hasMoreElements()) > { > + let entry = entries.nextFile; Nice cleanup in here.
Attachment #669256 -
Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) from comment #3) > ::: mailnews/base/prefs/content/am-junk.js > @@ +193,5 @@ > > function updateJunkTargetsAndRetention() { > > onCheckItem("server.moveTargetMode", ["server.moveOnSpam"]); > > updateJunkTargets(); > > onCheckItem("server.purgeSpam", ["server.moveOnSpam"]); > > + document.getElementById("purgeLabel").disabled = > > Why was this moved? If there wasn't a good reason, put it back please. :) This is intentional and just fixes a minor problem with patch from bug 725488.
Attachment #669256 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Comment 5•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/373ae165b4ce
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in
before you can comment on or make changes to this bug.
Description
•