Closed Bug 725517 Opened 10 years ago Closed 10 years ago

Error during configure after bug 683127: "line 25335: test: too many arguments"

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52

{
c:/mozilla/inbound/configure: line 25335: test: too many arguments
...
c:/mozilla/inbound/configure: line 25441: test: too many arguments
}

Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#9066
> if test -n "$MOZ_LINKER" -a -z "$MOZ_OLD_LINKER" -a $ac_cv_func_dladdr = no ; then

and...
http://mxr.mozilla.org/mozilla-central/source/configure.in#9073
> if test -n "$MOZ_LINKER" -a -z "$MOZ_OLD_LINKER" -a $ac_cv_func_dladdr = no; then

Added by bug 683127.

Build carries on regardless, perhaps another argument for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).
Does quoting "$ac_cv_func_dladdr" solve the issue?
Attached patch Patch v1Splinter Review
> Does quoting "$ac_cv_func_dladdr" solve the issue?

Yup :-)
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #595764 - Flags: review?(mh+mozilla)
Attachment #595764 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/40c94c17b303
Flags: in-testsuite-
Whiteboard: [qa-]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/40c94c17b303
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.