72588 - subsequent attempts to close mail window hang app and X

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[sairuh (rarely reading bugmail)]

i had run into this while going through bug 63897. if i reopen mail during the
same netscape6x session, then try to close it, both the app and X hangs for me.

the nasty problem with this bug is that it occurs with only my migrated 4.x
profile at work [on linux, which uses IMAP]. it does *not* occur with:

* non-migrated profile with the same mail account.
* non-migrated profile using a test mail account [ie, 3qatest01].
* migrated profile using POP [ie, my home account, also on linux].

i haven't tried this on win32 or Mac --mainly since i don't have roaming setup--
so the 4.x preferences are prolly quite different from my linux setup.

recipe
------
0. have a 4.76 profile which uses IMAP. please let me know if there are
particular prefs setting i should check here [i know there can be quite a few].
anyhow, i migrate this to netscape6x [eg, using 2001.03.19.11 verif comm bits].

note: btw, i've seen this bug occur with both an oldish migrated profile and a
freshly migrated one. in any case, i've been running into bug 69396 upon
migration --not sure if it's related here, since it was filed a few days after i
had first encountered this bug.

1. launch the app, making sure that mail isn't the only window open. ie, if you
only have mail open, select Tasks > Navigator; but if you have the browser
already open, that's fine, just make sure it remains open and select Tasks >
Mail.

2. login to mail.

3. close the mail window. wait about 10sec [bug 63897], then the window goes
away.

4. reopen mail.

5. try to close the mail window again.

results
-------
mail doesn't close, even after >10sec. i try to go to an xterm to kill the pid,
but the pointer won't bring other windows into focus. in fact, i cannot even
switch virtual desktops. i'm forced to jump out of X [ctrl+alt+f5], kill the
mozilla-bin pids, then jump back to X [ctrl+alt+f7].

another workaround is to open mail only once per session... but exiting and
restarting the app [esp with the current long startup time] doesn't seem very
reasonable to me.

Comment 1

[sairuh (rarely reading bugmail)]

kw-o-rama. adding nsdogfood since this definitely gets in the way of my daily
use of the app.

i went over this with nbaca, and unfortunately it doesn't affect her migrated
profile. :(  again, if there are settings i can check/toggle that could narrow
this down, pls do let me know!

however, here's a brief list of Things Already Tried That Didn't Make A
Difference For This Bug:

* theme doesn't matter --occurs with both modern and classic.
* still occurs with either 3-pane style [default or alternative].
* still occurs having biff on or off.
* still occurs having Outgoing smtp server never use SSL or using it when
available.

gonna try a few more things...

Comment 2

[sairuh (rarely reading bugmail)]

more testing:

my 4.x profile has two newsgroup servers [the internal 'news' server for
netscape, and 'news.mozilla.org']. i deleted both of 'em in my migrated profile,
but i still get the hanging.

anyhow, minor correction in my first comments --ctrl+alt+f4 is what gets me out
of X...

Comment 3

[sairuh (rarely reading bugmail)]

BenB, is bug 72182 the same as this bug?

StephenD, have you encountered this bug?

i'll try to get some imap log info the next time i'm in the office...

Comment 4

[Ben Bucksch (:BenB)]

A hanging X is bad.

se, X didn't hang for me. Dunno, if this is nevertheless the same bug (and just
our systems differ).

Comment 5

[sairuh (rarely reading bugmail)]

per bug 72182, i turned off the following mailnews account server settings:

* Clean up ("Expunge") Inbox on exit.
* Empty Trash on exit.

and i no longer experience the hang. moreover, i can do this with any IMAP
account with these settings turned on. since this isn't really a migration
issue, am wondering if this should go to either mail: backend, or network: imap.
i'll try the former, but pls do change as needed! [or, dup, if necessary.]

will attach mailnews prefs soon...

Comment 6

[sairuh (rarely reading bugmail)]

Attachment: prefs.js for test IMAP account w/bad settings ON

Comment 7

[sairuh (rarely reading bugmail)]

Attachment: IMAP log file with bad settings turned ON

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

I remember that Ben commented about the Empty Trash taking so long (Ben, I think
you even timed it) a while back, there is a bug that Jeff Tsai was assigned to,
I'm not sure if Ducarroz owns it now (but it's this problem, almost to a t.

Comment 9

[Scott MacGregor]

hey naving, are you interested in taking a look at this bug? bounce back to me
if you aren't =).

Comment 10

[esther]

per bug triage, I tried this on my linux system with today's build
2000-03-21-08.  I changed my IMAP server settings to use the IMAP delete model,
expunge Inbox on exit and Empty trash on exit.  I deleted 5 msgs and Exited. 
The exit took longer than when I don't have those setting checked, but it did
not hang.  sairuh did you delete a lot of messages? did you delete Messages with
large attachments?  Can you try this again with today's build. 

Comment 11

[sairuh (rarely reading bugmail)]

this is still occurring using today's 2001.03.21.08 comm bits [side note: the
attachment i added here were based on a new profile created using today's bits
as well.] esther, i didn't need to delete or do any thing to see this hang. the
X session hang i encountered occurred when i went into mail again during the
same session. if you have further questions, pls feel free to ping me over IM,
or drop by my cube!

Comment 12

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9.1

Comment 13

[Navin Gupta]

The close operation is slow, when you have these prefs turned on, but it 
does not hang. Please list steps on how to reproduce this ?

Comment 14

[sairuh (rarely reading bugmail)]

navin, i believe you're encountering bug 63897. this bug occurs during
*subsequent* attempts to close the mailnews window [with those prefs turned on].
to repro this, reopen mail [do *not* quit your mozilla/netscape6x session] and
try to close it again.

i'll go check if this is still a problem with recent builds...

i'll be happy to show you this in person, if you have further questions!

Comment 15

[sairuh (rarely reading bugmail)]

still occurs, and it's also xp. am using 2001.04.16.1x bits on linux and win32. 
also occurred using 2001.04.13.08 mac bits [i kept crashing when closing using 
2001.04.16.04 bits --prolly bug 74902]. will attach Macsbug stack trace [based on 
the hang with the 4/13 bits]...

Comment 16

[sairuh (rarely reading bugmail)]

Attachment: macsbug trace for hang using 2001.04.13.08 mac build

Comment 17

[Navin Gupta]

I think this is mac only, windows and linux works fine for me

Comment 18

[sairuh (rarely reading bugmail)]

chatted w/navin and confirmed this is still a problem [for me, at least] on all
platforms. thanks, navin!

Comment 19

[Navin Gupta]

Attachment: proposed fix

Comment 20

[Navin Gupta]

This hang happens on closing the mail second time. Somehow 
m_folderDoingEmptyTrash is not null so when we are doing cleanupinboxonexit 
we try to clear the emptytrashinprogress flag instead of 
clearing cleaninboxonexit flag which is why it gets into 
infinite loop. cc david for review. 

Comment 21

[David :Bienvenu]

boy, do I hate the way we're doing this whole cleanup stuff on exit. I think we
need to understand why m_folderDoingEmptyTrash is not null - otherwise, we're
basically poking at this with a stick. Is it the case that the problem occurs if
you pick both cleanup inbox on exit and empty trash on exit? Do they run
simultaneously?

Comment 22

[Navin Gupta]

Attachment: revised patch. Need review

Comment 23

[David :Bienvenu]

much better, sr=bienvenu

Comment 24

[Navin Gupta]

fix checked in. Note while verifying that closing the mail is slow, when you 
have both these option checked on. 

Comment 25

[esther]

I went to builds that would show the problem mac (4-10) and linux (4-9).  I did 
see the problem when the (2) account settings were on.  I then downloaded the 
mac build for today 2001-05-10 and ran the same test.  It did not crash or hang 
up opening and closing the mail window as it did with 4-10. I did see the 
slowness in closing mail as Navin warned, but basically this is fixed on Mac.
Still waiting for a linux commercial build today that I can use to test the fix. 
 But looks good so far. 

Comment 26

[sairuh (rarely reading bugmail)]

tried this out with a linux debug [16:44 pull], and it no longer hangs [with
those settings on]. thx a lot navin!

Comment 27

[Navin Gupta]

Marking verified based on last comment

Comment 28

[Navin Gupta]

*** Bug 72182 has been marked as a duplicate of this bug. ***