725885 - Worker interval timers can be deleted prematurely.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82779bfa0c2c

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/82779bfa0c2c

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 595910 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: setInterval timers in workers will disappear on slower machines.
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): Low risk.
String changes made by this patch: N/A

This fixes a bug in a web feature that causes it to randomly break depending on the speed of the machine.  The patch is simple enough that we could uplift it (as a bonus it fixes some randomorange bugs).

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 595910 [details] [diff] [review]
Patch

[Triage Comment]
Our earliest instance of this bug was from 2010 in comment 0 of 612311. Given the low-risk nature of the patch, we'll take it for Aurora 12. But we don't have any significant need for this on Beta, especially when we're only 3 weeks from finishing up the release.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3c833832242