692597 - Viewing video statistics should not be dependent upon control visibility

Status: RESOLVED WONTFIX

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 669260 added the ability to view statistics about the current video, but the implementation required that the controls be visible in order to see the statistics.

This bug is for separating that dependency, so statistics can be viewed even when controls are hidden.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 692597

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 565660 [details] [diff] [review]
Patch for bug 692597

I don't think we should do this.

I'd also worry that this could cause the controls to show up when they shouldn't.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Do you think a comment in both places (videocontrols.xml and html.css) warning about keeping html.css up-to-date could suffice?

I think this would make the UX of viewing statistics a little better, as well as keep the context menus predictable regardless of the enabled state of controls.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Moving to WONTFIX as the maintenance costs introduced by this change aren't worth the benefits.