nsSVGUtils::ToAppPixelRect rounds CSS px before scaling them, which means we get inaccurate results. Unfortunately we have tests that contain off numbers to compensate, but these inaccuracies are exaggerated even further by the kill-covered-regions patches in bug 614732, causing those tests to fail with those patches. In principle nsSVGUtils::ToAppPixelRect duplicates nsLayoutUtils::RoundGfxRectToAppRect, and the latter rounds properly making it more accurate. Switching to RoundGfxRectToAppRect gets me part way to solving the failures that occur with the kill-covered-regions patches in bug 614732.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #595918 - Flags: review?(roc)
Comment on attachment 595918 [details] [diff] [review] patch Actually, there's no reason to put this in roc's path (I was just in "it's display list stuff" mode).
Attachment #595918 - Flags: review?(roc) → review?(longsonr)
Attachment #595918 - Flags: review?(longsonr) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.