Last Comment Bug 725897 - Remove the inaccurate nsSVGUtils::ToAppPixelRect, and use nsLayoutUtils::RoundGfxRectToAppRect instead
: Remove the inaccurate nsSVGUtils::ToAppPixelRect, and use nsLayoutUtils::Roun...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Jonathan Watt [:jwatt]
:
Mentors:
Depends on:
Blocks: 614732 725903
  Show dependency treegraph
 
Reported: 2012-02-09 17:13 PST by Jonathan Watt [:jwatt]
Modified: 2012-02-10 19:47 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (14.06 KB, patch)
2012-02-09 17:14 PST, Jonathan Watt [:jwatt]
longsonr: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] 2012-02-09 17:13:20 PST
nsSVGUtils::ToAppPixelRect rounds CSS px before scaling them, which means we get inaccurate results. Unfortunately we have tests that contain off numbers to compensate, but these inaccuracies are exaggerated even further by the kill-covered-regions patches in bug 614732, causing those tests to fail with those patches.

In principle nsSVGUtils::ToAppPixelRect duplicates nsLayoutUtils::RoundGfxRectToAppRect, and the latter rounds properly making it more accurate. Switching to RoundGfxRectToAppRect gets me part way to solving the failures that occur with the kill-covered-regions patches in bug 614732.
Comment 1 Jonathan Watt [:jwatt] 2012-02-09 17:14:06 PST
Created attachment 595918 [details] [diff] [review]
patch
Comment 2 Jonathan Watt [:jwatt] 2012-02-10 03:04:51 PST
Passed Try.
Comment 3 Jonathan Watt [:jwatt] 2012-02-10 03:16:24 PST
Comment on attachment 595918 [details] [diff] [review]
patch

Actually, there's no reason to put this in roc's path (I was just in "it's display list stuff" mode).
Comment 4 Ed Morley [:emorley] 2012-02-10 19:47:45 PST
https://hg.mozilla.org/mozilla-central/rev/7faea8ebd049

Note You need to log in before you can comment on or make changes to this bug.