Last Comment Bug 725901 - RIL: Data call fixes
: RIL: Data call fixes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla13
Assigned To: Philipp von Weitershausen [:philikon]
:
Mentors:
Depends on:
Blocks: b2g-3g
  Show dependency treegraph
 
Reported: 2012-02-09 17:27 PST by Philipp von Weitershausen [:philikon]
Modified: 2012-02-10 11:31 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (16.66 KB, patch)
2012-02-09 17:28 PST, Philipp von Weitershausen [:philikon]
kyle: review+
Details | Diff | Review

Description Philipp von Weitershausen [:philikon] 2012-02-09 17:27:18 PST
Bug 713426 was a good start, but contains several typos (the code was never run, apparently) and some inconsistent behaviour wrt main thread notifications.
Comment 1 Philipp von Weitershausen [:philikon] 2012-02-09 17:28:01 PST
Created attachment 595919 [details] [diff] [review]
v1

Feex
Comment 2 Thinker Li [:sinker] 2012-02-09 19:17:48 PST
Comment on attachment 595919 [details] [diff] [review]
v1

Review of attachment 595919 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/b2g/ril_worker.js
@@ +1846,5 @@
> +          case DATACALL_INACTIVE:
> +            newDataCall.state = GECKO_NETWORK_STATE_DISCONNECTED;
> +            break;
> +          case DATACALL_ACTIVE_DOWN:
> +            newDataCall.state = GECKO_NETWORK_STATE_SUSPENDED;

On my SGS2, it is not actually suspended when a data call is active down.  And, it never goes to active up.  Is it a bug of rild extracted from SGS2?  (Bug #718903)
Comment 3 Philipp von Weitershausen [:philikon] 2012-02-10 11:04:58 PST
(In reply to Thinker Li [:sinker] from comment #2)
> ::: dom/system/b2g/ril_worker.js
> @@ +1846,5 @@
> > +          case DATACALL_INACTIVE:
> > +            newDataCall.state = GECKO_NETWORK_STATE_DISCONNECTED;
> > +            break;
> > +          case DATACALL_ACTIVE_DOWN:
> > +            newDataCall.state = GECKO_NETWORK_STATE_SUSPENDED;
> 
> On my SGS2, it is not actually suspended when a data call is active down. 
> And, it never goes to active up.  Is it a bug of rild extracted from SGS2? 
> (Bug #718903)

Good question. I will investigate that. We can always work around that with another "QUIRKS" thing if we find it's an SGS2-specific bug.
Comment 4 Kyle Machulis [:kmachulis] [:qdot] 2012-02-10 11:07:22 PST
Comment on attachment 595919 [details] [diff] [review]
v1

Review of attachment 595919 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me
Comment 5 Philipp von Weitershausen [:philikon] 2012-02-10 11:31:22 PST
Thanks!

https://hg.mozilla.org/mozilla-central/rev/6b5537115a23

Note You need to log in before you can comment on or make changes to this bug.