725901 - RIL: Data call fixes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Bug 713426 was a good start, but contains several typos (the code was never run, apparently) and some inconsistent behaviour wrt main thread notifications.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Feex

Comment 2

[Thinker Li [:sinker]]

Comment on attachment 595919 [details] [diff] [review]
v1

Review of attachment 595919 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/b2g/ril_worker.js
@@ +1846,5 @@
> +          case DATACALL_INACTIVE:
> +            newDataCall.state = GECKO_NETWORK_STATE_DISCONNECTED;
> +            break;
> +          case DATACALL_ACTIVE_DOWN:
> +            newDataCall.state = GECKO_NETWORK_STATE_SUSPENDED;

On my SGS2, it is not actually suspended when a data call is active down.  And, it never goes to active up.  Is it a bug of rild extracted from SGS2?  (Bug #718903)

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to Thinker Li [:sinker] from comment #2)
> ::: dom/system/b2g/ril_worker.js
> @@ +1846,5 @@
> > +          case DATACALL_INACTIVE:
> > +            newDataCall.state = GECKO_NETWORK_STATE_DISCONNECTED;
> > +            break;
> > +          case DATACALL_ACTIVE_DOWN:
> > +            newDataCall.state = GECKO_NETWORK_STATE_SUSPENDED;
> 
> On my SGS2, it is not actually suspended when a data call is active down. 
> And, it never goes to active up.  Is it a bug of rild extracted from SGS2? 
> (Bug #718903)

Good question. I will investigate that. We can always work around that with another "QUIRKS" thing if we find it's an SGS2-specific bug.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 595919 [details] [diff] [review]
v1

Review of attachment 595919 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me

Comment 5

[Philipp von Weitershausen [:philikon]]

Thanks!

https://hg.mozilla.org/mozilla-central/rev/6b5537115a23