Update table cellpadding / cellspacing to spec

RESOLVED FIXED in mozilla13

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla13
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 596028 [details] [diff] [review]
Patch v1

Currently, we call ParseSpecialIntValue ("rules for parsing dimension values" in the spec), and then pull out the percentage's value, and multiply it by 100 (for cellspacing only in quirks mode) to get the result we would already have got if we parsed the value as a simple integer.

It seems to make much more sense to just parse the value as the spec requires and remove all this hackery.
Attachment #596028 - Flags: review?(bzbarsky)

Comment 1

6 years ago
Comment on attachment 596028 [details] [diff] [review]
Patch v1

r=me
Attachment #596028 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/93e2945d9f73
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
In what way does this affect developers? I don't think it does.
(Assignee)

Comment 4

6 years ago
This made us interpret cellspacing=10% as 10 pixels outside quirks mode (was ignored previously). There may be something on the quirks mode page to update?
OK, based on what I'm reading here and in bug 106336, it sounds like it behaves the same in both quirks and non-quirks now then?
Docs updated:

https://developer.mozilla.org/en/Mozilla_Quirks_Mode_Behavior#Tables

And mentioned on Firefox 13 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.