Last Comment Bug 725977 - Update table cellpadding / cellspacing to spec
: Update table cellpadding / cellspacing to spec
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla13
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-02-10 06:03 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-02-23 12:52 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (5.27 KB, patch)
2012-02-10 06:03 PST, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2012-02-10 06:03:40 PST
Created attachment 596028 [details] [diff] [review]
Patch v1

Currently, we call ParseSpecialIntValue ("rules for parsing dimension values" in the spec), and then pull out the percentage's value, and multiply it by 100 (for cellspacing only in quirks mode) to get the result we would already have got if we parsed the value as a simple integer.

It seems to make much more sense to just parse the value as the spec requires and remove all this hackery.
Comment 1 User image Boris Zbarsky [:bz] (still a bit busy) 2012-02-10 12:41:39 PST
Comment on attachment 596028 [details] [diff] [review]
Patch v1

Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2012-02-21 11:00:49 PST
Comment 3 User image Eric Shepherd [:sheppy] 2012-02-23 07:51:00 PST
In what way does this affect developers? I don't think it does.
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2012-02-23 10:24:42 PST
This made us interpret cellspacing=10% as 10 pixels outside quirks mode (was ignored previously). There may be something on the quirks mode page to update?
Comment 5 User image Eric Shepherd [:sheppy] 2012-02-23 12:38:31 PST
OK, based on what I'm reading here and in bug 106336, it sounds like it behaves the same in both quirks and non-quirks now then?
Comment 6 User image Eric Shepherd [:sheppy] 2012-02-23 12:52:16 PST
Docs updated:

And mentioned on Firefox 13 for developers.

Note You need to log in before you can comment on or make changes to this bug.