725977 - Update table cellpadding / cellspacing to spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Currently, we call ParseSpecialIntValue ("rules for parsing dimension values" in the spec), and then pull out the percentage's value, and multiply it by 100 (for cellspacing only in quirks mode) to get the result we would already have got if we parsed the value as a simple integer.

It seems to make much more sense to just parse the value as the spec requires and remove all this hackery.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 596028 [details] [diff] [review]
Patch v1

r=me

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/93e2945d9f73

Comment 3

[Eric Shepherd [:sheppy]]

In what way does this affect developers? I don't think it does.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This made us interpret cellspacing=10% as 10 pixels outside quirks mode (was ignored previously). There may be something on the quirks mode page to update?

Comment 5

[Eric Shepherd [:sheppy]]

OK, based on what I'm reading here and in bug 106336, it sounds like it behaves the same in both quirks and non-quirks now then?

Comment 6

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en/Mozilla_Quirks_Mode_Behavior#Tables

And mentioned on Firefox 13 for developers.