New Tab Page should not respond to dragged bookmark folders

VERIFIED FIXED in Firefox 13

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: sdrocking, Assigned: ttaubert)

Tracking

Trunk
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When I drag a bookmark folder to the thumbnail position it gets pinned there. But nothing happens when I click on its thumbnail. Maybe it shouldn't get pinned in the first place. Or, maybe we should open all bookmarks within the folder.
(Reporter)

Updated

6 years ago
Blocks: 455553

Comment 1

6 years ago
Ouch! That makes my Firefox crash!

I have posted bug 726009 to keep this bug separated from the crash issue.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Created attachment 604922 [details] [diff] [review]
patch v1

Trivial patch with test.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #604922 - Flags: review?(dietrich)
Comment on attachment 604922 [details] [diff] [review]
patch v1

Review of attachment 604922 [details] [diff] [review]:
-----------------------------------------------------------------

r=me w/ the comment below added.

::: browser/base/content/newtab/drag.js
@@ +106,5 @@
>     */
>    isValid: function Drag_isValid(aEvent) {
>      let dt = aEvent.dataTransfer;
> +    let mimeType = "text/x-moz-url";
> +    return dt && dt.types.contains(mimeType) && dt.getData(mimeType);

there's some implicitness here that should be commented on. what's going on here and why?
Attachment #604922 - Flags: review?(dietrich) → review+
(In reply to Dietrich Ayala (:dietrich) from comment #3)
> > +    let mimeType = "text/x-moz-url";
> > +    return dt && dt.types.contains(mimeType) && dt.getData(mimeType);
> 
> there's some implicitness here that should be commented on. what's going on
> here and why?

Added.

Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/c1d32bb1b893
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/c1d32bb1b893
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
(Reporter)

Comment 6

6 years ago
Updating bug title from my understanding of the patch.
Summary: New Tab Page should not respond to dragged bookmark folders or should handle them properly → New Tab Page should not respond to dragged bookmark folders
Correct, thank you.

Updated

6 years ago
Blocks: 726009
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120409 Firefox/13.0a2
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120409 Firefox/14.0a1

Bookmark folders can't be dragged anymore in the new tab page. Setting to verified.
Status: RESOLVED → VERIFIED
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b550bf8631b5
You need to log in before you can comment on or make changes to this bug.