725996 - New Tab Page should not respond to dragged bookmark folders

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Siddhartha Dugar [:sdrocking]]

When I drag a bookmark folder to the thumbnail position it gets pinned there. But nothing happens when I click on its thumbnail. Maybe it shouldn't get pinned in the first place. Or, maybe we should open all bookmarks within the folder.

Comment 1

[Thomas Ahlblom]

Ouch! That makes my Firefox crash!

I have posted bug 726009 to keep this bug separated from the crash issue.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Trivial patch with test.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 604922 [details] [diff] [review]
patch v1

Review of attachment 604922 [details] [diff] [review]:
-----------------------------------------------------------------

r=me w/ the comment below added.

::: browser/base/content/newtab/drag.js
@@ +106,5 @@
>     */
>    isValid: function Drag_isValid(aEvent) {
>      let dt = aEvent.dataTransfer;
> +    let mimeType = "text/x-moz-url";
> +    return dt && dt.types.contains(mimeType) && dt.getData(mimeType);

there's some implicitness here that should be commented on. what's going on here and why?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> > +    let mimeType = "text/x-moz-url";
> > +    return dt && dt.types.contains(mimeType) && dt.getData(mimeType);
> 
> there's some implicitness here that should be commented on. what's going on
> here and why?

Added.

Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/c1d32bb1b893

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/c1d32bb1b893

Comment 6

[Siddhartha Dugar [:sdrocking]]

Updating bug title from my understanding of the patch.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Correct, thank you.

Comment 8

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120409 Firefox/13.0a2
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120409 Firefox/14.0a1

Bookmark folders can't be dragged anymore in the new tab page. Setting to verified.

Comment 9

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b550bf8631b5