Closed Bug 726505 Opened 8 years ago Closed 8 years ago

Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect, P4, minor)

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.10

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(2 files)

2 changesets to port:
http://hg.mozilla.org/mozilla-central/rev/7769be27ba62
http://hg.mozilla.org/mozilla-central/rev/61e6d741bd54

Note:
Don't use 'arguments.callee' (anymore), add/use function names.
Blocks: 726521
Depends on: 498339
No longer blocks: 725679
Comment on attachment 596609 [details] [diff] [review]
(Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey
[Checked in: Comment 11]

So, what's the point of the renames?

Also, when you write a function expression, the name of the function is only in scope inside the function itself, so you don't actually need to give your functions unique names. For instance, this is perfectly legal:

var foo = [ function foo() { return foo; } ];
Comment on attachment 596610 [details] [diff] [review]
(Bv1) Some space/line-ending cleanup
[Checked in: See comment 5]

r=me to fix the line endings, but the trailing spaces aren't worth the time.
Attachment #596610 - Flags: review?(neil) → review+
Comment on attachment 596610 [details] [diff] [review]
(Bv1) Some space/line-ending cleanup
[Checked in: See comment 5]

http://hg.mozilla.org/comm-central/rev/c22269a950d7
Bv1, with comment 4 suggestion(s).
Attachment #596610 - Attachment description: (Bv1) Some space/line-ending cleanup → (Bv1) Some space/line-ending cleanup [Checked in: See comment 5]
(In reply to neil@parkwaycc.co.uk from comment #3)

> So, what's the point of the renames?

Just to match the Firefox names, as we did previously for other tests: to ease maintenance, as in spare me history searches each time I do bugs like this one.

> you don't actually need to give your functions unique names.

Yeah, but I thought it can't hurt to be more explicit than that.
Yet, if you don't want the numbering, I'll remove it.
(In reply to Serge Gautherie from comment #6)
> (In reply to comment #3)
> > So, what's the point of the renames?
> Just to match the Firefox names, as we did previously for other tests
So the other three tests in the patch already use the Firefox name?
(In reply to neil@parkwaycc.co.uk from comment #7)
> So the other three tests in the patch already use the Firefox name?

Yes: all Firefox tests live in
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/
Attachment #596609 - Flags: review?(neil) → review+
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> Yet, if you don't want the numbering, I'll remove it.

Just to confirm, should I check it in with/without numbering?
(In reply to Serge Gautherie from comment #9)
> Just to confirm, should I check it in with/without numbering?
Yes, you can leave the numbering in.
Comment on attachment 596609 [details] [diff] [review]
(Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey
[Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/cff76f26dd7b
Attachment #596609 - Attachment description: (Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey → (Av1) Port |Bug 507784 - Some session restore tests don't correctly remove event listeners| to SeaMonkey [Checked in: Comment 11]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Blocks: 724441
You need to log in before you can comment on or make changes to this bug.