Pref needed to allow "Search Google for" tabs to open in background

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Menus
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: tracy.cooperjr, Assigned: Gavin)

Tracking

Trunk
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:13.0a1) Gecko/20120214 Firefox/13.0a1
Build ID: 20120214031227

Steps to reproduce:

Searched using context menu option "Search Google for".


Actual results:

Tab opened in Foreground.


Expected results:

Should have opened in background per "browser.tabs.loadInBackground" setting but due to Bug 695482 it no longer does.
Blocks: 695482
Status: UNCONFIRMED → NEW
Component: Untriaged → Menus
Ever confirmed: true
QA Contact: untriaged → menus
A new pref in about:config to override the changes in bug 695482 is required.

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86 → All

Updated

6 years ago
No longer blocks: 695482
Depends on: 695482
"is required" is a little strong. "is humbly requested" perhaps? :)

I want to be clear that the reason I'm going to fix this is:
- our previous behavior was long-standing, and some people have gotten used to it
- adding a pref is trivial, and introduces very little maintenance overhead

I don't want this to be perceived as a precedent that implies we'll be adding prefs to every new behavior change, because we aren't going to do that.
Created attachment 597265 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #597265 - Flags: review?(dao)
Thanks Gavin.  My statement 'is required' was meant to mean a new pref would be needed, rather than hooking the behavior of "browser.tabs.loadInBackground".  

Fully understood about it 'not becoming a norm' for changes.
Status: ASSIGNED → NEW
OS: All → Windows 7
Hardware: All → x86
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
Comment on attachment 597265 [details] [diff] [review]
patch

>+pref("browser.search.context.inBackground", false);

*.loadInBackground for consistency with similar prefs
Attachment #597265 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/dbf20cd5526f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

Updated

6 years ago
Blocks: 701903

Updated

a year ago
Depends on: 1293620
You need to log in before you can comment on or make changes to this bug.