727131 - Pref needed to allow "Search Google for" tabs to open in background

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[tracy.cooperjr]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:13.0a1) Gecko/20120214 Firefox/13.0a1
Build ID: 20120214031227

Steps to reproduce:

Searched using context menu option "Search Google for".


Actual results:

Tab opened in Foreground.


Expected results:

Should have opened in background per "browser.tabs.loadInBackground" setting but due to Bug 695482 it no longer does.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

A new pref in about:config to override the changes in bug 695482 is required.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

"is required" is a little strong. "is humbly requested" perhaps? :)

I want to be clear that the reason I'm going to fix this is:
- our previous behavior was long-standing, and some people have gotten used to it
- adding a pref is trivial, and introduces very little maintenance overhead

I don't want this to be perceived as a precedent that implies we'll be adding prefs to every new behavior change, because we aren't going to do that.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

Thanks Gavin.  My statement 'is required' was meant to mean a new pref would be needed, rather than hooking the behavior of "browser.tabs.loadInBackground".  

Fully understood about it 'not becoming a norm' for changes.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 597265 [details] [diff] [review]
patch

>+pref("browser.search.context.inBackground", false);

*.loadInBackground for consistency with similar prefs

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/dbf20cd5526f