Full screen does not work correctly on youtube.com

VERIFIED FIXED in Firefox 14

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
5 years ago
10 months ago

People

(Reporter: Camelia Urian, Assigned: snorp)

Tracking

Trunk
Firefox 15
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox14 verified, blocking-fennec1.0 betaN+)

Details

(Whiteboard: [QA^], URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 597382 [details]
Screenshot after full screen was selected

Fennec/13.0a1 2012-02-14
Device: HTC Desire (Android 2.2)

Steps to reproduce:
1. Make sure the Flash Plugin is installed.
2. Go to youtube.com and open any video.
3. Tap the full screen video control.
4. Try and scroll the page.

Expected results:
Video plays in full screen.

Actual results:
At step 3 the video is never set to full screen.
At step 4 if the page is scrolled the videoplayer is repainted but it is painted only a fraction of the screen size. 

Notes:
The issue is not reproducible on the Android Browser.
Assignee: nobody → snorp
tracking-fennec: --- → 13+
Keywords: fennecnative-releaseblocker
Priority: -- → P2
blocking-fennec1.0: --- → +
Status: NEW → ASSIGNED
On ICS, this seems to make Fennec unusable.
Priority: P2 → P1
Keeping on the blocker list; Damon + JP have the action to follow up with Adobe.

Comment 3

5 years ago
Assigning to self to get more info.
Assignee: snorp → jet
Whiteboard: [qa^]
I've figured out what was causing most of the wonky behavior here. Taking this one back.
Assignee: jet → snorp

Updated

5 years ago
Duplicate of this bug: 753124
Duplicate of this bug: 757499
Severity: normal → critical
status-firefox15: --- → affected
Whiteboard: [qa^] → [QA^]
Created attachment 626109 [details] [diff] [review]
Implement full screen support for Flash on Android
Attachment #626109 - Flags: review?(blassey.bugs)
The above patch works fine on Gingerbread, but has a problem on ICS; the video content is not painted. I've been trying to figure that one out for a while now, but this is at least better than what we do now (which is deadlock the browser).
Severity: critical → normal
status-firefox15: affected → ---
Comment on attachment 626109 [details] [diff] [review]
Implement full screen support for Flash on Android

Review of attachment 626109 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/base/android/ANPSurface.cpp
@@ +165,5 @@
>    LOG("Initialized? %d\n", gSurfaceFunctions.initialized);
>    return gSurfaceFunctions.initialized;
>  }
>  
> +// FIXME: All of this should be changed to use the equivalent things in AndroidBridge

file that bug

::: dom/plugins/base/android/ANPWindow.cpp
@@ +125,5 @@
> +    case kLandscape_ANPScreenOrientation:
> +      newOrientation = 6;
> +      break;
> +    case kPortrait_ANPScreenOrientation:
> +      newOrientation = 7;

can we define these magic numbers somewhere?

::: dom/plugins/base/nsNPAPIPluginInstance.cpp
@@ +73,5 @@
>  #ifdef MOZ_WIDGET_ANDROID
>      mSurface(nsnull),
>      mANPDrawingModel(0),
>      mOnScreen(true),
> +    mFullScreenOrientation(0 /* fixed landscape, see ActivityInfo class */),

again, no magic numbers

::: dom/plugins/base/nsPluginInstanceOwner.cpp
@@ +1743,4 @@
>    }
>  
>    if (AndroidBridge::Bridge())
> +    AndroidBridge::Bridge()->AddPluginView((jobject)mJavaView, aRect, mFullScreen, mInstance->FullScreenOrientation());

you need a jniframe and to check for an exception after this

@@ +1759,2 @@
>    if (AndroidBridge::Bridge())
> +    AndroidBridge::Bridge()->RemovePluginView((jobject)mJavaView, mFullScreen);

jniframe and exception check needed
Attachment #626109 - Flags: review?(blassey.bugs) → review+
Created attachment 628054 [details] [diff] [review]
Implement full screen support for Flash on Android
Attachment #628054 - Flags: review?(blassey.bugs)
Attachment #626109 - Attachment is obsolete: true
Attachment #628054 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/814d564578d1
This got backed out due to xul breakage. Working on a fix.
Relanded

https://hg.mozilla.org/integration/mozilla-inbound/rev/2910fc77173d
https://hg.mozilla.org/mozilla-central/rev/2910fc77173d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Does not work at all on ICS.
This is expected. Bug 759747
Depends on: 759747
Comment on attachment 628054 [details] [diff] [review]
Implement full screen support for Flash on Android

[Approval Request Comment]
User impact if declined: After pressing fullscreen buttons on Flash plugins, browser becomes unusable
Testing completed (on m-c, etc.): m-c for a couple weeks
Risk to taking this patch (and alternatives if risky): Bug 759747
String or UUID changes made by this patch: None
Attachment #628054 - Flags: approval-mozilla-aurora?
Comment on attachment 628054 [details] [diff] [review]
Implement full screen support for Flash on Android

[Triage Comment]
approved for beta (assuming that this is already on aurora)
Attachment #628054 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
blocking-fennec1.0: + → betaN+

Updated

5 years ago
Depends on: 761773
https://hg.mozilla.org/releases/mozilla-beta/rev/0bf3896da2e7

Updated

5 years ago
status-firefox14: --- → fixed
Unable to reproduce on:
Nightly 16.0a1 (2012-06-14)
Aurora 15.0a2 (2012-06-14)
Beta 14.0b7 Build 2

Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
tracking-fennec: 13+ → ---
status-firefox14: fixed → verified
You need to log in before you can comment on or make changes to this bug.