Rule view indicate when invalid values are entered

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Inspector
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: miker, Assigned: miker)

Tracking

({dev-doc-complete})

unspecified
Firefox 13
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ruleview])

Attachments

(3 attachments, 2 obsolete attachments)

Created attachment 597843 [details]
This is the webkit implementation ... we will do something like this

Now that user entered values can be entered in the rule view we need a way to signify the validity of user entered property values.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Priority: -- → P2
Created attachment 599651 [details] [diff] [review]
Patch

Much simpler than I expected.
Attachment #599651 - Flags: review?(dcamp)

Comment 2

5 years ago
Can you post a screenshot of this in action please?
Created attachment 599950 [details]
In Action

Sure, it looks almost identical to webkit's design. Hovering the warning symbol displays "Invalid property value" ... or at least it will do when bug 729539 is fixed (title & tooltips do not show tooltips in the sidebar).

The design may change when Jason has finished his mockup (bug 712469).
Whiteboard: [ruleview] → [ruleview][has-patch]
Attachment #599950 - Flags: feedback?(shorlander)
Comment on attachment 599950 [details]
In Action

I think this is perfectly fine for now. Knowing that you need to hover over the icon for the tooltip might not be immediately obvious. 

Probably worth some thought on if we can display this information in a less generic and more obvious way at some point.

Is that icon the right size for the height of the list items?
Attachment #599950 - Flags: feedback?(shorlander) → feedback+
Good point, I will shrink it a little before we land it
Created attachment 600094 [details] [diff] [review]
Shrunk icon as shorlander suggested

I have shrunk the icon a little as shorlander suggested.
Attachment #599651 - Attachment is obsolete: true
Attachment #600094 - Flags: review?(dcamp)
Attachment #599651 - Flags: review?(dcamp)

Comment 7

5 years ago
Comment on attachment 600094 [details] [diff] [review]
Shrunk icon as shorlander suggested

Review of attachment 600094 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy with it if shorlander's happy with the UI!

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +985,5 @@
>  
>      appendText(this.element, ";");
>  
> +    this.warning = createChild(this.element, "div", {
> +      // For an unknown reason the hidden attribute does not work here.

Is this comment still an issue?  It seems like it's working?
Attachment #600094 - Flags: review?(dcamp) → review+
Created attachment 600668 [details] [diff] [review]
Removed stray comment

(In reply to Dave Camp (:dcamp) from comment #7)
> Comment on attachment 600094 [details] [diff] [review]
> Shrunk icon as shorlander suggested
> 
> Review of attachment 600094 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm happy with it if shorlander's happy with the UI!
> 
> ::: browser/devtools/styleinspector/CssRuleView.jsm
> @@ +985,5 @@
> >  
> >      appendText(this.element, ";");
> >  
> > +    this.warning = createChild(this.element, "div", {
> > +      // For an unknown reason the hidden attribute does not work here.
> 
> Is this comment still an issue?  It seems like it's working?

Yes and no ... I added .ruleview-warning[hidden] { display: none; } to make it work but it should have worked without. Leaving this comment is confusing though so I have removed it.
Attachment #600094 - Attachment is obsolete: true
Whiteboard: [ruleview][has-patch] → [ruleview][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/399b98a618f3
Whiteboard: [ruleview][land-in-fx-team] → [ruleview][fixed-in-fx-team]
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/399b98a618f3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [ruleview][fixed-in-fx-team] → [ruleview]
Target Milestone: --- → Firefox 13
Documentation updated:

https://developer.mozilla.org/en/Tools/Page_Inspector/Style_panel#New_features_in_Firefox_13

Listed on Firefox 13 for developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.