727878 - [km] Accessibility review of Khmer localization

Status: RESOLVED FIXED

(Mozilla Localizations :: km / Khmer, defect)

Description

[Axel Hecht [:Pike]]

While reviewing the changes to Khmer, I noticed that there are a few cases where we're using "foo&rbar" to use 'r' as accesskey. The Khmer strings don't have a '&' and are thus not accessible. Notably, I found entries in  passwordmgr/passwordmgr.properties and search/search.properties in toolkit/chrome, and privateBrowsingYesTitle and siblings in browser/chrome/browser/browser.properties, cancelTitle and friends in quitDialog.properties. Also in browser/installer/*, and dom/chrome/dom/dom.properties, DontAskAgain. In toolkit/chrome/global/commonDialogs.properties:
Yes=&Yes
No=&No
Save=&Save
Revert=&Revert
DontSave=&Don't Save

On top of these, I see a mix between Khmer and latin chars as accesskeys. Does that work? I suspect that depending on keyboard, you have half the UI accessible and the other half not. If so, we should go for a single set of keyboard-accessible keys for access keys.

Accessibility (a11y) is big in Mozilla, so blocking the final release on this.

Comment 1

[Vannak Eng]

I just correct those accesskey to fit its message. so should i commit and put it again?

Comment 2

[Axel Hecht [:Pike]]

I see a bunch of landings in http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/e58d43e6c278 with accesskey changes. Those changes are looking good, thanks.

Are there more outstanding? Otherwise, I guess we can resolve this bug, but it'd be good to keep an eye open on a11y issues.

Comment 3

[Vannak Eng]

i think i don't have for now.

Comment 4

[Axel Hecht [:Pike]]

OK, resolving then.

Comment 5

[Axel Hecht [:Pike]]

Sadly, the landing for bug 727879, http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/38524a81ad96, regressed half of this :-(

Reopening.

Comment 6

[Vannak Eng]

what should I do with this then?

Comment 7

[Axel Hecht [:Pike]]

First I guess you need to figure out why it regressed. Any ideas? How did you fix it the first time, what did you do when you ended up reverting the change?

Comment 8

[Vannak Eng]

ok I'll redo it tomorrow and see if it work out.

Comment 9

[Vannak Eng]

i found the problem now. it is narro. it keeps those accesskeys untranslated after i export it. that is sad. :(

Comment 10

[Armen [:armenzg]]

If you point me to steps to reproduce I can look at it. I am more comfortable with Narro that I am proud of.

Comment 11

[Vannak Eng]

well, i just redo it and push it to repo.

Comment 12

[Vannak Eng]

Armen, I already made correction with those a11y but in the rev it still old translation. please help.

Comment 13

[Armen [:armenzg]]

Attachment: export

Exporting from Narro gives me this patch.

I see that properties files are having removed the "&" symbol.
From the description of this bug it seems that we have to get rid of the "&" symbol; is that we want to do?

Comment 14

[Vannak Eng]

yes that is what we want Armen.

Comment 15

[Axel Hecht [:Pike]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #13)
> Created attachment 599979 [details] [diff] [review]
> export
> 
> Exporting from Narro gives me this patch.
> 
> I see that properties files are having removed the "&" symbol.
> From the description of this bug it seems that we have to get rid of the "&"
> symbol; is that we want to do?

The opposite, we need to keep the ampersands in those strings.

Comment 16

[Vannak Eng]

i got the point now. Narro didn't save what i had changed. hmmmm... i'll keep checking it when all translated strings are saved and i'll commit it again.

Comment 17

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Vannak Eng from comment #16)
> i got the point now. Narro didn't save what i had changed. hmmmm... i'll
> keep checking it when all translated strings are saved and i'll commit it
> again.

from email, it looks like fallout from a bug in narro when exporting. Vannak + Arky are working through this, as I type. 



(In reply to Axel Hecht [:Pike] from comment #0)
...
> Accessibility (a11y) is big in Mozilla, so blocking the final release on
> this.
I agree this should block Khmer final release, but aiui, this doesnt block going to beta.

Comment 18

[Vannak Eng]

(In reply to Axel Hecht [:Pike] from comment #15)
> (In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment
> #13)
> > Created attachment 599979 [details] [diff] [review]
> > export
> > 
> > Exporting from Narro gives me this patch.
> > 
> > I see that properties files are having removed the "&" symbol.
> > From the description of this bug it seems that we have to get rid of the "&"
> > symbol; is that we want to do?
> 
> The opposite, we need to keep the ampersands in those strings.

Axel, I'm confused whether the string that has & is correct or incorrect. I start working on it locally so please guide me with that.

Comment 19

[Vannak Eng]

well, after observing each file i got that we need to have & in front of the alphabet that we want it to be the accesskey.

Comment 20

[Axel Hecht [:Pike]]

See http://mxr.mozilla.org/mozilla-aurora/source/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties#49 for example,

notNowButtonText = &Not Now

Sadly, there's no descent mxr search for all of them. But here's grep, giving a superset:

find * -name \*.properties | grep en-US|xargs grep -H '&'
b2g/locales/en-US/chrome/overrides/passwordmgr.properties:notNowButtonText = &Not Now
b2g/locales/en-US/chrome/overrides/passwordmgr.properties:neverForSiteButtonText = Ne&ver for This Site
b2g/locales/en-US/chrome/overrides/passwordmgr.properties:rememberButtonText = &Remember
browser/locales/en-US/chrome/browser/browser.properties:pasteAndGo.label=Paste & Go
browser/locales/en-US/chrome/browser/browser.properties:privateBrowsingYesTitle=&Start Private Browsing
browser/locales/en-US/chrome/browser/browser.properties:privateBrowsingNoTitle=&Cancel
browser/locales/en-US/chrome/browser/browser.properties:privateBrowsingNeverAsk=&Do not show this message again
browser/locales/en-US/chrome/browser/quitDialog.properties:quitTitle=&Quit
browser/locales/en-US/chrome/browser/quitDialog.properties:restartTitle=&Restart
browser/locales/en-US/chrome/browser/quitDialog.properties:cancelTitle=&Cancel
browser/locales/en-US/chrome/browser/quitDialog.properties:saveTitle=&Save and Quit
browser/locales/en-US/chrome/browser/search.properties:# search bar equivalent to the url bar's "Paste & Go"
browser/locales/en-US/chrome/browser/search.properties:cmd_pasteAndSearch=Paste & Search
browser/locales/en-US/chrome/browser/shellservice.properties:optionsLabel=%S &Options
browser/locales/en-US/chrome/browser/shellservice.properties:safeModeLabel=%S &Safe Mode
browser/locales/en-US/chrome/browser/syncGenericChange.properties:# LOCALIZATION NOTE (change.recoverykey.warningText) "Sync" should match &syncBrand.shortName.label; from syncBrand.dtd
browser/locales/en-US/chrome/browser-region/region.properties:browser.search.siteSearchURL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&q=site%3A{moz:domain}+{searchTerms}
browser/locales/en-US/chrome/browser-region/region.properties:gecko.handlerService.schemes.webcal.0.uriTemplate=http://30boxes.com/external/widget?refer=ff&url=%s
browser/locales/en-US/chrome/browser-region/region.properties:gecko.handlerService.schemes.mailto.1.uriTemplate=https://mail.google.com/mail/?extsrc=mailto&url=%s
browser/locales/en-US/feedback/main.properties:testpilot.page.commentsAndDiscussions = Comments & Discussions »
browser/locales/en-US/installer/custom.properties:# accesskey with an ampersand (e.g. &).
browser/locales/en-US/installer/custom.properties:CONTEXT_OPTIONS=$BrandShortName &Options
browser/locales/en-US/installer/custom.properties:CONTEXT_SAFE_MODE=$BrandShortName &Safe Mode
browser/locales/en-US/installer/custom.properties:MAINTENANCE_SERVICE_CHECKBOX_DESC=Install &Maintenance Service
browser/locales/en-US/installer/custom.properties:SUMMARY_TAKE_DEFAULTS=U&se $BrandShortName as my default web browser
browser/locales/en-US/installer/custom.properties:SURVEY_TEXT=&Tell us what you thought of $BrandShortName
browser/locales/en-US/installer/custom.properties:LAUNCH_TEXT=&Launch $BrandShortName now
browser/locales/en-US/installer/custom.properties:ICONS_DESKTOP=On my &Desktop
browser/locales/en-US/installer/custom.properties:ICONS_STARTMENU=In my &Start Menu Programs folder
browser/locales/en-US/installer/custom.properties:ICONS_QUICKLAUNCH=In my &Quick Launch bar
browser/locales/en-US/installer/custom.properties:UN_REMOVE_PROFILES=&Remove my $BrandShortName personal data and customizations
browser/locales/en-US/installer/custom.properties:OPTION_STANDARD_RADIO=&Standard
browser/locales/en-US/installer/custom.properties:OPTION_CUSTOM_RADIO=&Custom
browser/locales/en-US/installer/custom.properties:UPGRADE_BUTTON=&Upgrade
browser/locales/en-US/installer/mui.properties:# accesskey with an ampersand (e.g. &).
browser/locales/en-US/installer/mui.properties:MUI_BUTTONTEXT_FINISH=&Finish
browser/locales/en-US/installer/override.properties:# accesskey with an ampersand (e.g. &).
browser/locales/en-US/installer/override.properties:BackBtn=< &Back
browser/locales/en-US/installer/override.properties:NextBtn=&Next >
browser/locales/en-US/installer/override.properties:AcceptBtn=I &accept the terms in the License Agreement
browser/locales/en-US/installer/override.properties:DontAcceptBtn=I &do not accept the terms in the License Agreement
browser/locales/en-US/installer/override.properties:InstallBtn=&Install
browser/locales/en-US/installer/override.properties:UninstallBtn=&Uninstall
browser/locales/en-US/installer/override.properties:CloseBtn=&Close
browser/locales/en-US/installer/override.properties:BrowseBtn=B&rowse…
browser/locales/en-US/installer/override.properties:ShowDetailsBtn=Show &details
dom/locales/en-US/chrome/dom/dom.properties:DontAskAgain=&Don't ask me again
dom/locales/en-US/chrome/layout/htmlparser.properties:errLtSlashGt=Saw “</>”. Probable causes: Unescaped “<” (escape as “&lt;”) or mistyped end tag.
dom/locales/en-US/chrome/layout/htmlparser.properties:errBadCharAfterLt=Bad character after “<”. Probable cause: Unescaped “<”. Try escaping it as “&lt;”.
dom/locales/en-US/chrome/layout/htmlparser.properties:errLtGt=Saw “<>”. Probable causes: Unescaped “<” (escape as “&lt;”) or mistyped start tag.
dom/locales/en-US/chrome/layout/htmlparser.properties:errUnescapedAmpersandInterpretedAsCharacterReference=The string following “&” was interpreted as a character reference. (“&” probably should have been escaped as “&amp;”.)
dom/locales/en-US/chrome/layout/htmlparser.properties:errNotSemicolonTerminated=Named character reference was not terminated by a semicolon. (Or “&” should have been escaped as “&amp;”.)
dom/locales/en-US/chrome/layout/htmlparser.properties:errNoNamedCharacterMatch=“&” did not start a character reference. (“&” probably should have been escaped as “&amp;”.)
mobile/locales/en-US/chrome/region.properties:keyword.URL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=
mobile/locales/en-US/chrome/region.properties:gecko.handlerService.schemes.webcal.0.uriTemplate=http://30boxes.com/external/widget?refer=ff&url=%s
mobile/locales/en-US/chrome/region.properties:gecko.handlerService.schemes.mailto.1.uriTemplate=https://mail.google.com/mail/?extsrc=mailto&url=%s
toolkit/locales/en-US/chrome/global/commonDialogs.properties:Yes=&Yes
toolkit/locales/en-US/chrome/global/commonDialogs.properties:No=&No
toolkit/locales/en-US/chrome/global/commonDialogs.properties:Save=&Save
toolkit/locales/en-US/chrome/global/commonDialogs.properties:Revert=&Revert
toolkit/locales/en-US/chrome/global/commonDialogs.properties:DontSave=&Don't Save
toolkit/locales/en-US/chrome/global/printdialog.properties:# In the Windows labels, use an ampersand (&).
toolkit/locales/en-US/chrome/global/printdialog.properties:asLaidOutWindows=As &laid out on the screen
toolkit/locales/en-US/chrome/global/printdialog.properties:selectedFrameWindows=The selected &frame
toolkit/locales/en-US/chrome/global/printdialog.properties:separateFramesWindows=&Each frame separately
toolkit/locales/en-US/chrome/mozapps/update/updates.properties:updateAvailable_minor.text=Download & Install…
toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties:notNowButtonText = &Not Now
toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties:neverForSiteButtonText = Ne&ver for This Site
toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties:rememberButtonText = &Remember
toolkit/locales/en-US/chrome/search/search.properties:addEngineUseNowText=Start &using it right away

Comment 21

[Vannak Eng]

i just fixed it locally and now it comes to error and missing and obsolete here http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/6ba91bcb0011

Comment 22

[Axel Hecht [:Pike]]

That's because your editor added so-called BOM to the files, Byte-Order-Mark.

As they're code points without glyphs, you don't see them.

Make sure the file settings of your editor are set to not save with BOM.

Comment 23

[Vannak Eng]

axel, regardless the technical problem accesskey now is fine?

Comment 24

[Vannak Eng]

with this http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/7c91f9f324e5 can it be signoff?

Comment 25

[Vannak Eng]

Thanks god that narro comes to work as normal again. here are the revision

http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/2563487d567b
http://hg.mozilla.org/releases/l10n/mozilla-beta/km//rev/7fbecf420e17

i hope there is no problem for the beta build.

Comment 26

[arky [:arky]]

Axel, Trying to understand this issue and figure out what else needs to be fixed.



Rev 7c91f9f324e5 included change to custom.properties. Is this a problem ?


browser/installer/custom.properties@18:
-ICONS_DESKTOP=&នៅ​លើ​ផ្ទៃ​តុ​របស់​ខ្ញុំ
+ICONS_DESKTOP=នៅ​លើ​&ផ្ទៃ​តុ​របស់​ខ្ញុំ
 

en-US string has '&'. 
http://mxr.mozilla.org/mozilla-aurora/source/browser/locales/en-US/installer/custom.properties#75

Comment 27

[Vannak Eng]

the is no problem at because we have & in the translated string.