727903 - remove buildbot and other automation related to pageloader and fennecmark

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jeff Hammel]

with bug 725414 pageloader and fennecmark now live in talos.  While downloading the pageloader.xpi does not do any harm, it is no longer necessary and won't be used by newest talos.

Once all branches point to a talos.zip with pageloader/fennecmark included, all steps related to fetching and futzing with the resources may be eliminated

Comment 2

[Armen [:armenzg]]

All we have to do is modify this line:
http://hg.mozilla.org/mozilla-central/file/default/testing/talos/talos_from_code.py#l47
and remove the entry from talos.json:
http://hg.mozilla.org/mozilla-central/raw-file/default/testing/talos/talos.json

I don't even see the need to move pageloader.xpi to talos/page_load_test:
http://hg.mozilla.org/build/talos/file/56020a3a3bba/talos/page_load_test

I think all we need to do is submit such a patch with your new talos.zip to the try server and see how it fairs.

You can see both old and new code paths in this if clause:
http://hg.mozilla.org/build/buildbotcustom/file/default/process/factory.py#l7587

Do you want to give it a try and let me know how it goes?

== For more context ==

Right now all project branches, m-c and m-a do *not* download pageloader.xpi through the talos factory but through the talos_from_code.py script.

m-b and m-r will get there after merge days:
http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla-tests/config.py#l1268

The branches using talos_from_source_code.py hit this path code:
http://hg.mozilla.org/build/buildbotcustom/file/tip/process/factory.py#l7588

Comment 3

[Jeff Hammel]

> Do you want to give it a try and let me know how it goes?

Sure!

Comment 4

[Chris AtLee [:catlee]]

sounds like you got volunteered!

Comment 5

[Jeff Hammel]

Attachment: remove extraneous pieces

Comment 6

[Jeff Hammel]

Not sure the magical invocation of getting correct try syntax these days with autoland. This should be tried with, who would have guessed, talos runs

Comment 7

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 603517
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=bfa19d2d445c
Try run started, revision bfa19d2d445c. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=bfa19d2d445c

Comment 8

[Mozilla RelEng Bot]

Try run for bfa19d2d445c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=bfa19d2d445c
Results (out of 100 total builds):
    success: 99
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-bfa19d2d445c
 Timed out after 06 hours without completing.

Comment 9

[Armen [:armenzg]]

FYI your try push did not get any talos coverage, therefore, did not get tested.

You probably want to use (which I have added):
[autoland-try: -b o -p all -u none -t all]

FTR, the patch looks good but I would like to be 100% sure.

https://wiki.mozilla.org/Build:Autoland#Sample_Valid_tags

Comment 10

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 603517
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=a5edb129f0dd
Try run started, revision a5edb129f0dd. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=a5edb129f0dd

Comment 11

[Armen [:armenzg]]

Comment on attachment 603517 [details] [diff] [review]
remove extraneous pieces

This looks good. Thanks a lot!

Comment 12

[Jeff Hammel]

Could someone with m-c push access push this please?

Comment 13

[Armen [:armenzg]]

I will land this in the morning.

Comment 14

[Mozilla RelEng Bot]

Try run for a5edb129f0dd is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a5edb129f0dd
Results (out of 53 total builds):
    exception: 2
    success: 48
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a5edb129f0dd

Comment 15

[Armen [:armenzg]]

Comment on attachment 603517 [details] [diff] [review]
remove extraneous pieces

http://hg.mozilla.org/mozilla-central/rev/9ddf749edcf2

Comment 16

[Jeff Hammel]

Can we mark this as fixed? Or are there other pieces I don't know about?

Comment 17

[Jeff Hammel]

Marking as fixed.  Please reopen with details if i've missed anything