removing expired news articles broken

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Networking: NNTP
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({regression})

Trunk
Thunderbird 13.0
regression

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 597934 [details] [diff] [review]
proposed fix

the url we run to get rid of expired articles is failing. Patch upcoming
Attachment #597934 - Flags: review?(Pidgeot18)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
OS: Windows 7 → Windows 2000
Hardware: x86_64 → All
Summary: removing expired news articles borken → removing expired news articles broken
I'd feel a lot better about this if we could test it.

Updated

6 years ago
Keywords: regression
OS: Windows 2000 → All
I don't think this is quite enough--I tested it briefly (by accident, natch) and the result I got appears to be that it cleared the newsgroup but it also opened up the file dialog "do you want to open the file mozilla.dev.test.multimedia?"...
URL:
(Assignee)

Comment 3

6 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> I don't think this is quite enough--I tested it briefly (by accident, natch)
> and the result I got appears to be that it cleared the newsgroup but it also
> opened up the file dialog "do you want to open the file
> mozilla.dev.test.multimedia?"...

Did you try it with the patch in bug 492329 ? That's the only way I've tried it, and I did not get the file dialog.
Comment on attachment 597934 [details] [diff] [review]
proposed fix

I finally did a more purposeful test of this, and it worked this time. The UI for clearing messages kind of sucks (you see no apparent visual cue that anything is happening until the operation finishes, when messages disappear), but that's probably worth another bug.

Some other notes:
1. Lose the comment (or at least the "I think")
2. return rv; probably ought to be return NS_OK;
3. It's probably cleaner to separate the if statement from the rest of the code with blank lines.
Attachment #597934 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 5

6 years ago
fixed on trunk - forgot to address the comments; I'll do that later today
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/comm-central/rev/c7d25333f38a pushed for review comments.

Updated

6 years ago
Duplicate of this bug: 739934
Duplicate of this bug: 743432
Duplicate of this bug: 749803
You need to log in before you can comment on or make changes to this bug.