Last Comment Bug 728493 - Add Lion window opening animation (zoom on creation) to Thunderbird
: Add Lion window opening animation (zoom on creation) to Thunderbird
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Nomis101
:
Mentors:
Depends on: 674370
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-17 16:56 PST by Nomis101
Modified: 2012-02-27 04:04 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (3.66 KB, patch)
2012-02-17 16:56 PST, Nomis101
standard8: review+
bwinton: ui‑review+
Details | Diff | Review

Description Nomis101 2012-02-17 16:56:25 PST
Created attachment 598442 [details] [diff] [review]
Patch

This patch will add the window animation in Lion to the standalone window, the main window, the addressbook and the compose window.
Comment 1 Cameron McCormack (:heycam) 2012-02-17 17:01:17 PST
I don't think the Address Book window is document-like.  It's kind of similar to the Bookmarks window in Firefox.  I don't think it should zoom on opening.
Comment 2 Nomis101 2012-02-18 16:04:19 PST
I don't know if the Address Book window is document-like, but it looks nice if it zooms on opening in my tests. But I also have no problems to remove it.
Comment 3 Blake Winton (:bwinton) (:☕️) 2012-02-22 13:42:41 PST
Comment on attachment 598442 [details] [diff] [review]
Patch

I agree with Nomis, it does look nice opening, so I'm gonna say ui-r=me.

Thanks,
Blake.
Comment 4 Mark Banner (:standard8) 2012-02-24 03:05:45 PST
Comment on attachment 598442 [details] [diff] [review]
Patch

Being on 10.6 I can't test this, but the code looks right and Blake's happy, so r=me.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-02-26 12:33:36 PST
http://hg.mozilla.org/comm-central/rev/e1f2344bacb9

To make life easier for those checking in patches for you, please follow the directions below to make future patches easier to work with. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Note You need to log in before you can comment on or make changes to this bug.