728810 - Port bug 553092 - Initialise the permissions manager only on startup

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P2)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #553092 +++

Bug 553092 did some work to improve initialisation of the permissions manager on startup.

We should port that to Thunderbird - we basically need to port the browser.js part (to LightWeightThemeWebInstaller in msgMail3PaneWindow.js) and the permissions.js part to the like file in Thunderbird.

Comment 1

[:aceman]

What is the way to test this?

Comment 2

[Mark Banner (:standard8)]

You probably want to check that themes installed from somewhere listed in the whitelist prefs aren't blocked:

http://mxr.mozilla.org/comm-central/search?string=xpinstall.whitelist.add&find=%2Fprofile%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

For the permissions.js part, I don't think we actually display that dialog in Thunderbird atm.

Comment 3

[:aceman]

You mean they should work the same before and after the change?
How can I install themes in Thunderbird?

Comment 4

[Mark Banner (:standard8)]

(In reply to :aceman from comment #3)
> You mean they should work the same before and after the change?

Yep

> How can I install themes in Thunderbird?

Tools -> Addons -> Get Add-ons -> See All Themes -> Personas -> Select a persona

(needs to be a persona rather than a general theme though).

Comment 5

[:aceman]

Ok, let's try it.

Comment 6

[:aceman]

Strange, those 2 prefs are reset to "" when I visit that site offering personas.
But the personas still apply (preview).

Comment 7

[:aceman]

Attachment: patch

After applying this and trying the steps in comment 4 the personas still apply, without asking.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 599313 [details] [diff] [review]
patch

For future reference, to fully test this, you either need a new profile, or to nuke permissions.sqlite and then test installing personas.

I did this after a bit of trial and error, and doubly confirmed that everything still works as expected, so r=me.

Comment 9

[:aceman]

Thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/8adfa5fe33fa