Port bug 553092 - Initialise the permissions manager only on startup

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: aceman)

Tracking

Trunk
Thunderbird 13.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #553092 +++

Bug 553092 did some work to improve initialisation of the permissions manager on startup.

We should port that to Thunderbird - we basically need to port the browser.js part (to LightWeightThemeWebInstaller in msgMail3PaneWindow.js) and the permissions.js part to the like file in Thunderbird.
(Assignee)

Comment 1

5 years ago
What is the way to test this?
(Reporter)

Comment 2

5 years ago
You probably want to check that themes installed from somewhere listed in the whitelist prefs aren't blocked:

http://mxr.mozilla.org/comm-central/search?string=xpinstall.whitelist.add&find=%2Fprofile%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

For the permissions.js part, I don't think we actually display that dialog in Thunderbird atm.
(Assignee)

Comment 3

5 years ago
You mean they should work the same before and after the change?
How can I install themes in Thunderbird?
(Reporter)

Comment 4

5 years ago
(In reply to :aceman from comment #3)
> You mean they should work the same before and after the change?

Yep

> How can I install themes in Thunderbird?

Tools -> Addons -> Get Add-ons -> See All Themes -> Personas -> Select a persona

(needs to be a persona rather than a general theme though).
(Assignee)

Comment 5

5 years ago
Ok, let's try it.
Assignee: nobody → acelists
(Assignee)

Comment 6

5 years ago
Strange, those 2 prefs are reset to "" when I visit that site offering personas.
But the personas still apply (preview).
(Assignee)

Comment 7

5 years ago
Created attachment 599313 [details] [diff] [review]
patch

After applying this and trying the steps in comment 4 the personas still apply, without asking.
Attachment #599313 - Flags: review?(mbanner)
(Reporter)

Comment 8

5 years ago
Comment on attachment 599313 [details] [diff] [review]
patch

For future reference, to fully test this, you either need a new profile, or to nuke permissions.sqlite and then test installing personas.

I did this after a bit of trial and error, and doubly confirmed that everything still works as expected, so r=me.
Attachment #599313 - Flags: review?(mbanner) → review+
(Assignee)

Comment 9

5 years ago
Thanks.
Status: NEW → ASSIGNED
Keywords: helpwanted → checkin-needed
http://hg.mozilla.org/comm-central/rev/8adfa5fe33fa
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.