Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 728810 - Port bug 553092 - Initialise the permissions manager only on startup
: Port bug 553092 - Initialise the permissions manager only on startup
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: Thunderbird 13.0
Assigned To: :aceman
Depends on: 553092
  Show dependency treegraph
Reported: 2012-02-20 01:11 PST by Mark Banner (:standard8)
Modified: 2012-02-26 15:39 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (3.72 KB, patch)
2012-02-21 12:59 PST, :aceman
standard8: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2012-02-20 01:11:45 PST
+++ This bug was initially created as a clone of Bug #553092 +++

Bug 553092 did some work to improve initialisation of the permissions manager on startup.

We should port that to Thunderbird - we basically need to port the browser.js part (to LightWeightThemeWebInstaller in msgMail3PaneWindow.js) and the permissions.js part to the like file in Thunderbird.
Comment 1 :aceman 2012-02-20 01:16:07 PST
What is the way to test this?
Comment 2 Mark Banner (:standard8) 2012-02-20 06:34:45 PST
You probably want to check that themes installed from somewhere listed in the whitelist prefs aren't blocked:^[^\0]*%24&hitlimit=&tree=comm-central

For the permissions.js part, I don't think we actually display that dialog in Thunderbird atm.
Comment 3 :aceman 2012-02-20 06:48:50 PST
You mean they should work the same before and after the change?
How can I install themes in Thunderbird?
Comment 4 Mark Banner (:standard8) 2012-02-20 07:24:44 PST
(In reply to :aceman from comment #3)
> You mean they should work the same before and after the change?


> How can I install themes in Thunderbird?

Tools -> Addons -> Get Add-ons -> See All Themes -> Personas -> Select a persona

(needs to be a persona rather than a general theme though).
Comment 5 :aceman 2012-02-20 07:29:32 PST
Ok, let's try it.
Comment 6 :aceman 2012-02-21 12:15:06 PST
Strange, those 2 prefs are reset to "" when I visit that site offering personas.
But the personas still apply (preview).
Comment 7 :aceman 2012-02-21 12:59:12 PST
Created attachment 599313 [details] [diff] [review]

After applying this and trying the steps in comment 4 the personas still apply, without asking.
Comment 8 Mark Banner (:standard8) 2012-02-24 04:29:37 PST
Comment on attachment 599313 [details] [diff] [review]

For future reference, to fully test this, you either need a new profile, or to nuke permissions.sqlite and then test installing personas.

I did this after a bit of trial and error, and doubly confirmed that everything still works as expected, so r=me.
Comment 9 :aceman 2012-02-24 04:39:15 PST
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-02-26 12:33:47 PST

Note You need to log in before you can comment on or make changes to this bug.