728861 - The last action taken on about:addons is added as an item to the add-on list

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Camelia Urian]

Attachment: Screen shot

Fennec/13.0a1 2012-02-19
Device: HTC Desire (Android 2.2)

Steps to reproduce:
1. Go to about:addons or access it using the add-on menu.
2. Select one of the items
3. Change it from Enable to Disable.
3. Wait a few seconds.

Expected results:
 The add-on is correctly disabled, the user is not returned to the add-on list

Actual results:
After a few seconds the user is returned to the addons list and a new item - the previous action - is added to the list.

Notes:
 - On Aurora 12.0a1 the user is not returned to the addon list until the back button is pressed.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The search engine observer calls getAddons to refresh the list when a search engine is enabled/disabled.  The problem is that this also makes the list items visible, even if the detail page is still showing.

This patch factors the showing of the list into a separate function.  (It also removes a line that set the unused "showlist" attribute.)

Comment 2

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24810c9c6ae7

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/24810c9c6ae7

Comment 4

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-03-01)
20120301031135
http://hg.mozilla.org/mozilla-central/rev/1c3b291d0830

--
Device: Samsung Galaxy S2
OS: Android 2.3.4