Closed
Bug 728945
Opened 12 years ago
Closed 12 years ago
3 text selection reftests are failing on android native vs android xul
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-fennec1.0 -)
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
blocking-fennec1.0 | --- | - |
People
(Reporter: jmaher, Assigned: jmaher)
References
(Blocks 1 open bug)
Details
(Whiteboard: [android][tegra][talos][android_tier_1])
Attachments
(1 file)
1.28 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
3 tests from: http://mxr.mozilla.org/mozilla-central/source/layout/reftests/selection/reftest.list fails-if(Android) != pseudo-element-of-native-anonymous.html pseudo-element-of-native-anonymous-ref.html # bug 676641 # These tests uses Highlight and HighlightText color keywords, they are not same as text selection color on Mac. fails-if(cocoaWidget) == non-themed-widget.html non-themed-widget-ref.html fails-if(cocoaWidget) == themed-widget.html themed-widget-ref.html it seems that for the first test we incorrectly run the test (unexpected pass) on android XUL and we correctly run the test on android native (expected fail). Since Android is a single condition, we can't split this. We need to figure out why this fails on XUL and fix that as another condition other than OS. The last two pass on Android XUL, but fail on Android Native. It appears that our selected background color is grey with white text vs black with yellow text. Not sure if there is a window manager or graphics layer that we can use to determine if this is valid or not.
Assignee | ||
Comment 1•12 years ago
|
||
I don't like this patch, but this bug has not received any feedback from the mobile developers as to why these tests are failing. We need to get these test runs green and unhidden.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #601988 -
Flags: review?(blassey.bugs)
Attachment #601988 -
Flags: feedback?(jruderman)
Updated•12 years ago
|
Attachment #601988 -
Flags: review?(blassey.bugs) → review+
Comment 2•12 years ago
|
||
What do the failures look like? Do we need to add CSS color keywords for the text selection color?
Updated•12 years ago
|
blocking-fennec1.0: --- → -
Updated•12 years ago
|
Attachment #601988 -
Flags: feedback?(jruderman)
Assignee | ||
Comment 3•12 years ago
|
||
seems that a m-c update fixed this.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•