728999 - browser_526613.js should not use 'about:robots' which is Firefox specific

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Serge Gautherie (:sgautherie)]

This test passes nonetheless, but better use 'about:mozilla' for example.

****

Ftr, to be checked afterward,

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329768128.1329772780.9739.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/20 12:02:08  
{
...
TEST-PASS | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Restoring the old state should have left this window open
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]
************************************************************

INFO TEST-END | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | finished in 3275ms

TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_526613.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIURI.equals]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://communicator/content/viewZoomOverlay.js :: <TOP_LEVEL> :: line 238"  data: no]" {file: "chrome://communicator/content/viewZoomOverlay.js" line: 238}]
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications [Checked in: Comment 3]

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 599039 [details] [diff] [review]
(Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications
[Checked in: Comment 3]

Review of attachment 599039 [details] [diff] [review]:
-----------------------------------------------------------------

It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS changes are always ported, I assumed the tests were as well, in which case it should be fixed in comm-central...

The change is fine but it's entirely likely that there will be more tests that don't run in Seamonkey...

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 599039 [details] [diff] [review]
(Av1) browser_526613.js: Use "about:mozilla", instead of "about:robots", to support non-Firefox applications
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/246bc1c98175


(In reply to Paul O'Shannessy [:zpao] from comment #2)

> It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS

Obviously.

> changes are always ported, I assumed the tests were as well, in which case
> it should be fixed in comm-central...

Bug 729000.

> The change is fine but it's entirely likely that there will be more tests
> that don't run in Seamonkey...

Bug 728626.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> (In reply to Paul O'Shannessy [:zpao] from comment #2)
> > It's in m-c/browser/ so it's by definition a Firefox test, right? Since SS
> 
> Obviously.

My point here is that there isn't really a reason to fix this in m-c and if a test isn't working in comm-central, the fix really belongs there.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Paul O'Shannessy [:zpao] from comment #4)
> My point here is that there isn't really a reason to fix this in m-c and if
> a test isn't working in comm-central, the fix really belongs there.

The reason is to reduce differences. Why use specific resources when not required?

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> (In reply to Paul O'Shannessy [:zpao] from comment #4)
> > My point here is that there isn't really a reason to fix this in m-c and if
> > a test isn't working in comm-central, the fix really belongs there.
> 
> The reason is to reduce differences. Why use specific resources when not
> required?

The whole service is specific to Firefox. I'm fine taking the changes but I don't agree with the mentality that we should think about Seamonkey when writing Firefox tests. Compatibility with Seamonkey should be handled by whomever is doing the porting.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to Paul O'Shannessy [:zpao] from comment #6)

> The whole service is specific to Firefox. I'm fine taking the changes but I
> don't agree with the mentality that we should think about Seamonkey when

Sad :-|

> writing Firefox tests. Compatibility with Seamonkey should be handled by
> whomever is doing the porting.

Isn't that what I'm working on?

Comment 8

[Serge Gautherie (:sgautherie)]

V.Fixed, as 'mochitest-browser-chrome' still succeed.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Ftr, to be checked afterward,

Done in bug 729000 comment 4.