729019 - Add Android/mips support

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Makoto Kato [:m_kato] (PTO until 5/6)]

Today, I have ordered Ainovo NOVO7 that uses XBusrt 1GHZ (mips).

Let's add Android/mips target since MIPS releases Android NDK for mips chip.

Comment 1

[Makoto Kato [:m_kato] (PTO until 5/6)]

Attachment: fix

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 603966 [details] [diff] [review]
fix

Review of attachment 603966 [details] [diff] [review]:
-----------------------------------------------------------------

::: pr/include/pratom.h
@@ +140,2 @@
>             (defined(__powerpc__) && !defined(__powerpc64__)) || \
> +           ((defined(__arm__) || defined(__i386__) || defined(__mips__)) && \

I'm having a real hard time following what you've done here. It doesn't help that this conditional was a huge mess in the first place. Can you explain this?

::: pr/include/md/_linux.h
@@ +224,5 @@
> +
> +#define _MD_ATOMIC_INCREMENT(ptr) __sync_add_and_fetch(ptr, 1)
> +#define _MD_ATOMIC_DECREMENT(ptr) __sync_sub_and_fetch(ptr, 1)
> +#define _MD_ATOMIC_SET(ptr, nv) __sync_lock_test_and_set(ptr, nv)
> +#define _MD_ATOMIC_ADD(ptr, i) __sync_add_and_fetch(ptr, i)

I don't know the first thing about MIPS, so I'm assuming you know this works properly.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 603966 [details] [diff] [review]
fix

Clearing review until my questions are answered.

Comment 4

[Makoto Kato [:m_kato] (PTO until 5/6)]

Android NDK r8 supports MIPS, but mips toolchain name is different of old toolchanin by MIPS.  So I need update patch.

(In reply to Ted Mielczarek [:ted] from comment #2)
> Comment on attachment 603966 [details] [diff] [review]
> fix
> 
> Review of attachment 603966 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: pr/include/pratom.h
> @@ +140,2 @@
> >             (defined(__powerpc__) && !defined(__powerpc64__)) || \
> > +           ((defined(__arm__) || defined(__i386__) || defined(__mips__)) && \
> 
> I'm having a real hard time following what you've done here. It doesn't help
> that this conditional was a huge mess in the first place. Can you explain
> this?

This supports is for atomic built-in function by GCC.
 
> ::: pr/include/md/_linux.h
> @@ +224,5 @@
> > +
> > +#define _MD_ATOMIC_INCREMENT(ptr) __sync_add_and_fetch(ptr, 1)
> > +#define _MD_ATOMIC_DECREMENT(ptr) __sync_sub_and_fetch(ptr, 1)
> > +#define _MD_ATOMIC_SET(ptr, nv) __sync_lock_test_and_set(ptr, nv)
> > +#define _MD_ATOMIC_ADD(ptr, i) __sync_add_and_fetch(ptr, i)
> 
> I don't know the first thing about MIPS, so I'm assuming you know this works
> properly.

Yes.  this is for using gcc built-in function.  If __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4, gcc supports __sync_* for intptr on 32-bit OS.

But I should split a bug for gcc atomic support on various CPU.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Allow to build for mipsel with Android NDK r8

This is enough to build nspr with NDK r8, targetting mipsel-linux-android. I'll let Kato-san file a separate bug for atomic support.

Comment 6

[Mike Hommey [:glandium]]

The patch depends on the patch from bug 756575.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Allow to build for mipsel with Android NDK r8 (libffi part)

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 625367 [details]
Allow to build for mipsel with Android NDK r8 (libffi part)

Wrong bug for this patch.

Comment 9

[(not currently active) Ted Mielczarek]

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.330; previous revision: 1.329
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.333; previous revision: 1.332
done

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee50deb510b

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ee50deb510b

Comment 12

[(no longer active)]

NSPR upgrade: https://hg.mozilla.org/mozilla-central/rev/22a080ac092e