Last Comment Bug 756575 - android-platform detection is broken for android-x86
: android-platform detection is broken for android-x86
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Android
: -- normal (vote)
: mozilla15
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on: 735223
Blocks: 729019 756740
  Show dependency treegraph
 
Reported: 2012-05-18 13:08 PDT by Ted Mielczarek [:ted.mielczarek]
Modified: 2012-06-02 12:05 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix android-platform detection for android-x86 (2.17 KB, patch)
2012-05-18 23:29 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review
Fix android-platform detection for android-x86 (nspr part) (1.24 KB, patch)
2012-05-18 23:29 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Ted Mielczarek [:ted.mielczarek] 2012-05-18 13:08:51 PDT
Just specifying --with-android-version isn't enough, you have to specify --with-android-platform to make things work. We should be able to autodetect the platform dir.
Comment 1 Mike Hommey [:glandium] 2012-05-18 23:29:03 PDT
Created attachment 625357 [details] [diff] [review]
Fix android-platform detection for android-x86
Comment 2 Mike Hommey [:glandium] 2012-05-18 23:29:16 PDT
Created attachment 625358 [details] [diff] [review]
Fix android-platform detection for android-x86 (nspr part)
Comment 3 Ted Mielczarek [:ted.mielczarek] 2012-05-19 09:32:04 PDT
Comment on attachment 625357 [details] [diff] [review]
Fix android-platform detection for android-x86

Review of attachment 625357 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably yank this whole Android toolchain section out into an m4 file at some point.
Comment 4 Ted Mielczarek [:ted.mielczarek] 2012-05-19 09:43:25 PDT
Comment on attachment 625358 [details] [diff] [review]
Fix android-platform detection for android-x86 (nspr part)

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.329; previous revision: 1.328
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.332; previous revision: 1.331
done
Comment 7 :Ehsan Akhgari 2012-06-02 12:05:41 PDT
NSPR upgrade: https://hg.mozilla.org/mozilla-central/rev/22a080ac092e

Note You need to log in before you can comment on or make changes to this bug.