android-platform detection is broken for android-x86

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: glandium)

Tracking

Trunk
mozilla15
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Just specifying --with-android-version isn't enough, you have to specify --with-android-platform to make things work. We should be able to autodetect the platform dir.
Depends on: 735223
Assignee: nobody → mh+mozilla
Created attachment 625357 [details] [diff] [review]
Fix android-platform detection for android-x86
Attachment #625357 - Flags: review?(ted.mielczarek)
Created attachment 625358 [details] [diff] [review]
Fix android-platform detection for android-x86 (nspr part)
Attachment #625358 - Flags: review?(ted.mielczarek)
Blocks: 729019
Blocks: 756740
No longer blocks: 729019
Blocks: 729019
(Reporter)

Comment 3

5 years ago
Comment on attachment 625357 [details] [diff] [review]
Fix android-platform detection for android-x86

Review of attachment 625357 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably yank this whole Android toolchain section out into an m4 file at some point.
Attachment #625357 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Updated

5 years ago
Attachment #625358 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Comment 4

5 years ago
Comment on attachment 625358 [details] [diff] [review]
Fix android-platform detection for android-x86 (nspr part)

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.329; previous revision: 1.328
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.332; previous revision: 1.331
done
https://hg.mozilla.org/integration/mozilla-inbound/rev/b18288b53788
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee50deb510b
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/b18288b53788
https://hg.mozilla.org/mozilla-central/rev/7ee50deb510b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
NSPR upgrade: https://hg.mozilla.org/mozilla-central/rev/22a080ac092e
You need to log in before you can comment on or make changes to this bug.