756575 - android-platform detection is broken for android-x86

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Just specifying --with-android-version isn't enough, you have to specify --with-android-platform to make things work. We should be able to autodetect the platform dir.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix android-platform detection for android-x86

Comment 2

[Mike Hommey [:glandium]]

Attachment: Fix android-platform detection for android-x86 (nspr part)

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 625357 [details] [diff] [review]
Fix android-platform detection for android-x86

Review of attachment 625357 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably yank this whole Android toolchain section out into an m4 file at some point.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 625358 [details] [diff] [review]
Fix android-platform detection for android-x86 (nspr part)

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.329; previous revision: 1.328
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.332; previous revision: 1.331
done

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b18288b53788
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ee50deb510b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b18288b53788
https://hg.mozilla.org/mozilla-central/rev/7ee50deb510b

Comment 7

[(no longer active)]

NSPR upgrade: https://hg.mozilla.org/mozilla-central/rev/22a080ac092e