729396 - ML dmg should use (a modified version of) the diagrammatic background

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Translations, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

As I was looking over the 2.1.1 ML dmg last night, it occurred to me that we have this lovely no-text, l10n-friendly diagrammatic background designed specifically so we could use it on the ML dmg also, but we're not using it there :-(

I got a copy of Jasper's .psd, and philippe is going to resize the header in order to make it look good at a typical ML dmg width.

I'll supply a .DS_Store file once everything's all set up, and Marcello can plug the new background and .DS_Store into his dmg-generation script for 2.1.2 :)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Early WIP based on philippe's early WIP

Just to give an idea, this is an early WIP of the .dmg based on philippe's early WIP of the background.

It's based on standard 10.5 spacing using the icon/font sizes of the regular Camino.dmg (64x64 and 12pt), with everything moved up a bunch.

The regular .dmg uses a lot tighter spacing (maybe 50% of 10.5's default vertical distance), so there's probably some more room for tightening, but given the fact that "Available Languages.rtf" is two lines, there's not a lot to play with between the first and second rows.

We could also play with the layout in other ways (moving the RTF to the second row and centering the app), and so forth.

This is a 606x550 window below the title bar ('bounds of Finder window "Camino Mulitlingual"').

Comment 2

[philippe (part-time)]

Attachment: background-l10n - wip v0.5

Here is an updated wip of the background image.

It is sized 606x596px - I don't think the height matters much (taller than the window won't mess things up).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: WIP screenshot based on philippe's wip v0.5

Here's a new screenshot based on philippe's wip v0.5.  I'm still not perfectly happy with the layout (and I want to write a better tool to change the layout so there's less nudging involved), but it was generated using the new wrapper script I wrote to make running it easy for Marcello.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: WIP .DS_Store

The corresponding (WIP) .DS_Store file.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: WIP wrapper script to drive the assembly process

Here's not-the-world's-best-shell-script that I wrote to drive the packaging.

Assuming you have

1) A folder containing the .dmg contents (app, Available Languages.rtf, ReadMe folders),

2) A folder containing the resources: disk image icon (disk.icns; a new version is being readied in bug 416270), the background here (attachment 599481 [details]), and the .DS_Store here (attachment 602261 [details]),

3) A copy of pkg-dmg (http://mxr.mozilla.org/mozilla1.9.2/source/build/package/mac_osx/pkg-dmg?raw=1),

4) A copy of build-ML-dmg (this attachment), and

4) Both pkg-dmg and build-ML-dmg are executable

then

./build-ML-dmg -v 2.1.1 -s /path/to/contents/folder -r /path/to/resources/folder -t /path/to/output/folder -p /path/to/pkg-dmg

should create Camino-2.1.1-MultiLang.dmg in /path/to/output/folder, and that .dmg should look like attachment 602260 [details] when mounted.

(-p -r -s -t can all be specified permanently in the script for easy future execution, so normally you could just do 'build-ML-dmg -v 2.1.1'; right now those variables in the script are all set up for my testing.)

Marcello, can you try this out and see if you get the expected results on your CaminoML packaging Mac?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: .DS_Store v1.0

Here's a .DS_Store I'm happy with; it has been produced programmatically rather the by me trying to drag things to the right places.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: AppleScript used to generate the .DS_Store

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 602689 [details]
AppleScript used to generate the .DS_Store

Here's the AppleScript I used to size and position the window and set the final icon positions (I manually ordered and had the Finder auto-snap so they were all on grid first).

The spacing between the "header" and the top of the Camino icon is now the same as in the English-only .dmg.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: WIP wrapper script to drive the assembly process (updated)

I had my "and" and "or" confused when writing this; this fix makes the format-selection sanity check work :P

Other than that, and the fact there's an updated .DS_Store (attachment 602688 [details]), the rest of comment 5 still applies.

Comment 10

[Marcello Testi]

Attachment: Edits done by Marcello (mostly local)

Comment 11

[Marcello Testi]

I've tested the script and the resulting DMG fails to show the background.

I had to manually run xcode-select -switch before running.
I also had to manually pass UDZO (which is the one currently produced by my building routine) as --format, since the default UDBZ is unrecognized on my system.

Comment 12

[Marcello Testi]

Attachment: Better management for arguments passed for creating filename

I switched back to the original version of the script and only changed the logic flaw about the filename (which was assigned before validation arguments).

Now calling the script as: 
sudo sh build-ML-dmg.sh -v 2.1.1-test -f UDZO -r ~/Documents/Camino/Camino_2.1 -s ~/Documents/Camino/Camino_2.1/Camino\ Multilingual -t ~/Documents/Camino/Camino_2.1 -p ~/Documents/Camino/package-mac_osx/pkg-dmg
works, but the resulting DMG doesn't have a background image.

Could the .DS_Store a bit too tied to Smokey's environment?

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Marcello Testi from comment #11)

> I had to manually run xcode-select -switch before running.
I guess it knows no value until run once?  That's unfortunate :-( We could switch that to hardcoding /Developer instead, assuming that everyone has at least 1 Xcode install in /Developer, but I think Xcode 4.2 is now a self-contained package instead of a /Developer folder hierarchy, so hardcoding wouldn't work there.

Or I guess just test-run the command and parse the output :-(

> I also had to manually pass UDZO (which is the one currently produced by my
> building routine) as --format, since the default UDBZ is unrecognized on my
> system.

Really? What OS version are you building on?  UDBZ has been supported since 10.4 (and the default for Mozilla apps since Gecko 1.9).

> Could the .DS_Store a bit too tied to Smokey's environment?

My understanding was that it was only looking for the picture to be present in $dmg/.background/.

Maybe I've set it up wrong and need to make the .DS_Store reference $dmg/.background/background.png as the picture source.  When I'm back on the other Mac in a little bit, I'll spin a new .DS_Store that does that.

Yeah, that looks to be it; I compared a release .DS_Store to mine, and the vaguely-human-readable part of the release .DS_Store only has .background/background.jpg as a path, while mine references a full path on my system.  I have no idea how mento got it to use the relative path, so let's hope the OS picture-setting UI Does The Right Thing™…

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: .DS_Store v1.2

Marcello, try this for the .DS_Store.

(There's still some extraneous garbage in the file, e.g. the local path to the .dmg, that's not in mento's hand-tuned .DS_Store files, but since I'm not mento and can't parse .DS_Store in my head, let's just be happy that this .DS_Store appears to reference the background picture by disk name ["Camino Multilingual"] and the hidden folder.)

Comment 15

[Marcello Testi]

Attachment: Screenshot of resulting DMG window

Yeah! Looks OK, now.

Regarding the DMG format: The problem lied with an old version of pkg-dmg I was using. Upgrading to the version linked above fixed it

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Wrapper script to drive the assembly process, v0.9

(In reply to Marcello Testi from comment #15)
> Created attachment 602749 [details]
> Screenshot of resulting DMG window
> 
> Yeah! Looks OK, now.

:D

> Regarding the DMG format: The problem lied with an old version of pkg-dmg I
> was using. Upgrading to the version linked above fixed it

Aha!  Now our ML .dmgs will be ~5% smaller, too :)

--

Marcello, here's an updated wrapper script that incorporates your change from 12, rewrites the SetFile check to deal with the xcode-select issue from comment 11 and related issues described in comment 13, and does s proper file check on the resource files once their paths have been (re)set.

Assuming this new script still works fine, the only thing to change between 0.9 and 1.0 will be un-setting (or changing) the pre-defined values for VER, DIMMIDGE, and the resource file _PATHs (wherever we check in the script, we should not check it in with user-specific paths ;) ).

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: AppleScript used to generate the .DS_Store (updated)

The changes to this version of the window-arranging script are mostly cosmetic; I used variables in a couple of cases and beefed up some comments.  This also sets a couple of window properties in addition to the icon view options properties.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: .DS_Store v1.2.1 (includes German ReadMe folder)

Here's a .DS_Store that also handles the German ReadMe folder, since German may be coming for 2.1.2.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So, now that we've shipped this in a release, I'd like to get the key parts landed in version control somewhere.

I don't particularly care where (Camino's hg or caminol10n's cvs), although I think it would be nice to have the l10n .DS_Store and background the same location that the rest of the packaging files (disk.icns and the non-l10n background and .DS_Store) live, hg.m.o/camino/resources/package.  Similarly, it seems like build-ML-dmg is most closely related to buildint.sh and should live in caminol10n cvs with buildint.sh.

Marcello, what do you think?

Comment 20

[Marcello Testi]

I would open a new bug regarding cleaning up the current VCS setup, so that everything could be found more easily.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Marcello Testi from comment #20)
> I would open a new bug regarding cleaning up the current VCS setup, so that
> everything could be found more easily.

I'm not sure what you mean here.

Comment 22

[Takanori MATSUURA]

This bug lies at rest in the graveyard.