Closed
Bug 729430
Opened 13 years ago
Closed 13 years ago
Expose screen.mozEnabled, screen.mozBrightness to whitelisted applications
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(2 files, 2 obsolete files)
971 bytes,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
2.83 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #599507 -
Flags: review?(justin.lebar+bug)
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #599515 -
Flags: review?(jones.chris.g)
What's this going to be used for?
Comment 3•13 years ago
|
||
My understanding is we need this so the telephony app can wake up the screen when we receive a call.
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #2) > What's this going to be used for? What Justin's says. Basically this is to workaround https://github.com/andreasgal/gaia/pull/299 and bug 720831 and bug 720892
Comment 5•13 years ago
|
||
Comment on attachment 599507 [details] [diff] [review] Patch Can you move the IsChromeType(mDocShell) check into IsWhitelisted? If you just want the docshell's document, you can nsCOMPtr<nsIDocument> doc = do_QueryInterface(aDocShell) r- because I'd like to take another look. I promise to be quick.
Attachment #599507 -
Flags: review?(justin.lebar+bug) → review-
Comment on attachment 599515 [details] [diff] [review] Add http://localhost:7777 to the whitelist Sure, makes sense.
Attachment #599515 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Attachment #599507 -
Attachment is obsolete: true
Attachment #599562 -
Flags: review?(justin.lebar+bug)
Assignee | ||
Comment 8•13 years ago
|
||
Sorry, wrong version!
Attachment #599562 -
Attachment is obsolete: true
Attachment #599563 -
Flags: review?(justin.lebar+bug)
Attachment #599562 -
Flags: review?(justin.lebar+bug)
Comment 9•13 years ago
|
||
> + nsCOMPtr<nsIDocument> doc = do_QueryInterface(aDocShell); do_GetInterface. Sorry, I mistyped in comment 5.
Comment 10•13 years ago
|
||
Comment on attachment 599563 [details] [diff] [review] Patch v0.2 Do you need the IsChromeType check? I'd be kind of surprised if IsChromeType(aDocShell) does not imply that the document's principal's URI is chrome. r=me if you test and it works (I don't think the current patch will work with do_QueryInterface instead of do_GetInterface), but I'd appreciate if you got rid of the IsChromeType if it's not necessary.
Attachment #599563 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to Justin Lebar [:jlebar] from comment #10) > Comment on attachment 599563 [details] [diff] [review] > Patch v0.2 > > Do you need the IsChromeType check? I'd be kind of surprised if > IsChromeType(aDocShell) does not imply that the document's principal's URI > is chrome. > > r=me if you test and it works (I don't think the current patch will work > with do_QueryInterface instead of do_GetInterface), but I'd appreciate if > you got rid of the IsChromeType if it's not necessary. The patch works but needs to keep the IsChromeType check. https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0828cb6427 https://hg.mozilla.org/integration/mozilla-inbound/rev/19cdcc585460
Comment 12•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba0828cb6427 https://hg.mozilla.org/mozilla-central/rev/19cdcc585460
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•