729430 - Expose screen.mozEnabled, screen.mozBrightness to whitelisted applications

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Add http://localhost:7777 to the whitelist

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

What's this going to be used for?

Comment 3

[Justin Lebar (not reading bugmail)]

My understanding is we need this so the telephony app can wake up the screen when we receive a call.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> What's this going to be used for?

What Justin's says.

Basically this is to workaround https://github.com/andreasgal/gaia/pull/299 and bug 720831 and bug 720892

Comment 5

[Justin Lebar (not reading bugmail)]

Comment on attachment 599507 [details] [diff] [review]
Patch

Can you move the IsChromeType(mDocShell) check into IsWhitelisted?

If you just want the docshell's document, you can

  nsCOMPtr<nsIDocument> doc = do_QueryInterface(aDocShell)

r- because I'd like to take another look.  I promise to be quick.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 599515 [details] [diff] [review]
Add http://localhost:7777 to the whitelist

Sure, makes sense.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Sorry, wrong version!

Comment 9

[Justin Lebar (not reading bugmail)]

> +  nsCOMPtr<nsIDocument> doc = do_QueryInterface(aDocShell);

do_GetInterface.  Sorry, I mistyped in comment 5.

Comment 10

[Justin Lebar (not reading bugmail)]

Comment on attachment 599563 [details] [diff] [review]
Patch v0.2

Do you need the IsChromeType check?  I'd be kind of surprised if IsChromeType(aDocShell) does not imply that the document's principal's URI is chrome.

r=me if you test and it works (I don't think the current patch will work with do_QueryInterface instead of do_GetInterface), but I'd appreciate if you got rid of the IsChromeType if it's not necessary.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Justin Lebar [:jlebar] from comment #10)
> Comment on attachment 599563 [details] [diff] [review]
> Patch v0.2
> 
> Do you need the IsChromeType check?  I'd be kind of surprised if
> IsChromeType(aDocShell) does not imply that the document's principal's URI
> is chrome.
> 
> r=me if you test and it works (I don't think the current patch will work
> with do_QueryInterface instead of do_GetInterface), but I'd appreciate if
> you got rid of the IsChromeType if it's not necessary.

The patch works but needs to keep the IsChromeType check.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0828cb6427
https://hg.mozilla.org/integration/mozilla-inbound/rev/19cdcc585460

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ba0828cb6427
https://hg.mozilla.org/mozilla-central/rev/19cdcc585460