maple: Buffer rotation appears broken on engadget

VERIFIED FIXED in Firefox 14

Status

()

P1
normal
VERIFIED FIXED
7 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: cwiiis)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox14 verified, firefox15 verified, blocking-fennec1.0 beta+)

Details

(Whiteboard: MAPLE mwc-demo)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Chris Lord says:
Buffer rotation doesn't appear to be working. At least on Engadget, I'm
constantly seeing huge uploads when scrolling a small amount.
(Reporter)

Updated

7 years ago
Blocks: 729391
Assignee: nobody → chrislord.net

Updated

7 years ago
Whiteboard: maple → MAPLE mwc-demo
Keywords: fennecnative-betablocker

Updated

7 years ago
Priority: -- → P1
(Assignee)

Comment 1

7 years ago
Just to note, it appears broken on pretty much every site to a certain degree, but Engadget is particularly badly affected.
blocking-fennec1.0: --- → beta+
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
Created attachment 601563 [details] [diff] [review]
Fix retaining layers when the displaylist children of a scroll layer change

roc debugged this with me yesterday, and we(...he) discovered that buffer rotation isn't being used effectively on Engadget because we don't seem to be retaining layers as we scroll down the page.

This is because the frame used to retain a layer when there are multiple children of a scroll layer is the last one, which has a tendency to change. This patch makes it use the first child instead, which tends to be more stable.

The proper fix would be to associate it with a frame that definitely won't change, but this is a low-risk quick fix that I imagine helps in the majority of cases (and certainly fixes the engadget.com case).

This has a dramatic effect on performance for Maple.
Attachment #601563 - Flags: review?(roc)
(Assignee)

Comment 3

7 years ago
For reference, a try run looks good: https://tbpl.mozilla.org/?tree=Try&rev=bf681c51d65e
(Assignee)

Comment 4

7 years ago
Comment on attachment 601563 [details] [diff] [review]
Fix retaining layers when the displaylist children of a scroll layer change

Changing reviewer to mats, given that roc was the one that came up with the fix.
Attachment #601563 - Flags: review?(roc) → review?(matspal)
Comment on attachment 601563 [details] [diff] [review]
Fix retaining layers when the displaylist children of a scroll layer change

Seems a bit random, but if it works better, sure.  r=mats
Add a XXX comment and file a bug on making a proper fix?
Attachment #601563 - Flags: review?(matspal) → review+
(Assignee)

Comment 6

7 years ago
Created attachment 601629 [details] [diff] [review]
Fix retaining layers when the displaylist children of a scroll layer change

Attaching final committed patch for reference.
Attachment #601563 - Attachment is obsolete: true
Attachment #601629 - Flags: review+
https://hg.mozilla.org/projects/maple/rev/d137bbd5fe5b

Chris, make sure you file a proper fix and link it from this bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

7 years ago
The proper fix is filed as bug 731641 (and the comment checked in mentions this also).
(Reporter)

Updated

7 years ago
Blocks: 717774
Target Milestone: --- → mozilla14
Verified fixed on:

Firefox 15.0a1 (2012-05-29)
Firefox 14.0a2 (2012-05-29)

Device: Galaxy Nexus
OS: Android 4.0.2
Status: RESOLVED → VERIFIED
status-firefox14: --- → verified
status-firefox15: --- → verified
You need to log in before you can comment on or make changes to this bug.