729537 - Maple: buffers are larger than we expect

Status: VERIFIED FIXED

(Core :: Graphics, defect, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

Chris Lord:
We have *huuuge* buffers - I'm not sure where the size is coming from (the displayport set on buffers is only 300 pixels around the screen size). This means that we often deal with uploads in the region of 2000+ pixels (even on a 1024x600 screen), for no real reason. No area of the page outside of the 300 pixel buffer set in the displayport is rendered.

Comment 1

[Chris Lord [:cwiiis]]

Got a fix incoming for this one.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Fix displayport setting

Fix bad buffer sizes by making sure the displayport is set correctly at all times.

Unfortunately, this patch seems to interact badly with the recent rotation fixes - I'm taking a look at that next, but will submit a separate patch (as I think that may be an issue with those changes, rather than with this patch).

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Fix displayport setting

Ok, the fix was so small there's no point in me uploading a separate patch. Carry on :)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 599955 [details] [diff] [review]
Fix displayport setting

Looks OK. Took me a little while to walk the different code paths. Looks like the viewport code could be getting a cleanup refactor soon.

Comment 5

[Chris Lord [:cwiiis]]

Pushed: http://hg.mozilla.org/projects/maple/rev/15e3fc38103f

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Please test bug 729922 and also going to bugzilla.mozilla.org when verifying this bug.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

So this changes the invalidation rectangles we get on runfield, which decreases our performance. I do not understand why.

Comment 8

[Cristian Nicolae (:xti)]

Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-29)
Device: Galaxy Nexus
OS: Android 4.0.2