Occasionally an update will trigger the following warning: 2012-02-22 19:20:16.406178 UTC - -655362304[7f47d9852df0]: nsUrlClassifierDBServiceWorker::BeginStream 2012-02-22 19:20:16.406187 UTC - -655362304[7f47d9852df0]: Expecting MAC in this stream 2012-02-22 19:20:16.406829 UTC - -655362304[7f47d9852df0]: ###!!! ASSERTION: ProcessHostSub should only be called for prefix hashes.: 'mChunkState.hashSize == PREFIX_SIZE', file /home/morbo/hg/mozilla-central/toolkit/components/url-classifier/ProtocolParser.cpp, line 706 2012-02-22 19:20:16.407616 UTC - -22583520[7f47fd85b150]: OnDataAvailable (14180 bytes) 2012-02-22 19:20:16.407791 UTC - -22583520[7f47fd85b150]: OnDataAvailable (1418 bytes) 2012-02-22 19:20:16.410594 UTC - -22583520[7f47fd85b150]: OnDataAvailable (2836 bytes)
Okay, this is a really stupid bug. It's only the assertion that is wrong. It's sitting in ProcessHostSubComplete not ProcessHostSub, but was copypasted from there without changing PREFIX_SIZE into COMPLETE_SIZE. What's slightly surprising to me is that there are actual SubCompletes out there being used in the wire protocol.
Created attachment 600034 [details] [diff] [review] Patch 1. Fix the assertion check and message.
Created attachment 616609 [details] [diff] [review] Patch 1. Backout [Approval Request Comment] Backout due to bug 744993: a01cf079ee0b Bug 730247 1a6d008acb4f Bug 729928 f8bf3795b851 Bug 729640 35bf0d62cc30 Bug 726002 a010dcf1a973 Bug 726002 e9291f227d63 Bug 725597 db52b4916cde Bug 673470 173f90d397a8 Bug 673470
Comment on attachment 616609 [details] [diff] [review] Patch 1. Backout Sorry - thought this bug was reopened because the backout was backed out. My mistake. Approved for Aurora 13 (or Beta 13 if the merge occurs before we land).
Relanding after fixes in bug 673470 to fix bug 744993. https://hg.mozilla.org/integration/mozilla-inbound/rev/0f125c23208c