Closed Bug 729640 Opened 12 years ago Closed 12 years ago

Protocol parsing is broken in UrlClassifier

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Version:
13 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 17

People

(Reporter: gcp, Assigned: gcp)

Details

Attachments

(2 files)

Patch 1. Fix the assertion check and message.
1.32 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
Patch 1. Backout
1.30 KB, patch
akeybl
: approval-mozilla-aurora+
mfinkle
: approval-mozilla-central+
Details | Diff | Splinter Review 
Occasionally an update will trigger the following warning:

2012-02-22 19:20:16.406178 UTC - -655362304[7f47d9852df0]: nsUrlClassifierDBServiceWorker::BeginStream
2012-02-22 19:20:16.406187 UTC - -655362304[7f47d9852df0]: Expecting MAC in this stream
2012-02-22 19:20:16.406829 UTC - -655362304[7f47d9852df0]: ###!!! ASSERTION: ProcessHostSub should only be called for prefix hashes.: 'mChunkState.hashSize == PREFIX_SIZE', file /home/morbo/hg/mozilla-central/toolkit/components/url-classifier/ProtocolParser.cpp, line 706
2012-02-22 19:20:16.407616 UTC - -22583520[7f47fd85b150]: OnDataAvailable (14180 bytes)
2012-02-22 19:20:16.407791 UTC - -22583520[7f47fd85b150]: OnDataAvailable (1418 bytes)
2012-02-22 19:20:16.410594 UTC - -22583520[7f47fd85b150]: OnDataAvailable (2836 bytes)
Okay, this is a really stupid bug. It's only the assertion that is wrong. It's sitting in ProcessHostSubComplete not ProcessHostSub, but was copypasted from there without changing PREFIX_SIZE into COMPLETE_SIZE.

What's slightly surprising to me is that there are actual SubCompletes out there being used in the wire protocol.
Assignee: nobody → gpascutto

        Attachment #600034 -
        Flags: review?(dcamp)

    
  

        Attachment #600034 -
        Flags: review?(dcamp) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f8bf3795b851
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch 1. Backout
        — 
          — Splinter Review
      

    


  
[Approval Request Comment]
Backout due to bug 744993:

a01cf079ee0b Bug 730247
1a6d008acb4f Bug 729928
f8bf3795b851 Bug 729640
35bf0d62cc30 Bug 726002
a010dcf1a973 Bug 726002
e9291f227d63 Bug 725597
db52b4916cde Bug 673470
173f90d397a8 Bug 673470

        Attachment #616609 -
        Flags: approval-mozilla-central?

        Attachment #616609 -
        Flags: approval-mozilla-aurora?

        Attachment #616609 -
        Flags: approval-mozilla-central? → approval-mozilla-central+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/01d2f5d68c15
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  

        Attachment #616609 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

    
    

    
  
Comment on attachment 616609 [details] [diff] [review]
Patch 1. Backout

Sorry - thought this bug was reopened because the backout was backed out. My mistake. Approved for Aurora 13 (or Beta 13 if the merge occurs before we land).

        Attachment #616609 -
        Flags: approval-mozilla-aurora- → approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0f125c23208c
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 13 → Firefox 17
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: