Closed Bug 729928 Opened 11 years ago Closed 11 years ago

Cleanup unused cache preferences

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Version:
13 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 17

People

(Reporter: gcp, Assigned: gcp)

Details

Attachments

(2 files)

Patch 1. Remove unused sqlite3 prefs
4.36 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
Patch. Backout
4.34 KB, patch
akeybl
: approval-mozilla-aurora+
mfinkle
: approval-mozilla-central+
Details | Diff | Splinter Review 
We have some preferences relating to the old sqlite-based urlclassifier left. Clean them up.

        Attachment #599992 -
        Flags: review?(dcamp)

    
  
Assignee: nobody → gpascutto

    
  

        Attachment #599992 -
        Flags: review?(dcamp) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1a6d008acb4f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch. Backout
        — 
          — Splinter Review
      

    


  
Backout due to bug 744993:

a01cf079ee0b Bug 730247
1a6d008acb4f Bug 729928
f8bf3795b851 Bug 729640
35bf0d62cc30 Bug 726002
a010dcf1a973 Bug 726002
e9291f227d63 Bug 725597
db52b4916cde Bug 673470
173f90d397a8 Bug 673470

        Attachment #616614 -
        Flags: approval-mozilla-central?

        Attachment #616614 -
        Flags: approval-mozilla-aurora?

        Attachment #616614 -
        Flags: approval-mozilla-central? → approval-mozilla-central+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/936582807ae9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  

        Attachment #616614 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

    
    

    
  
Comment on attachment 616614 [details] [diff] [review]
Patch. Backout

Sorry - thought this bug was reopened because the backout was backed out. My mistake. Approved for Aurora 13 (or Beta 13 if the merge occurs before we land).

        Attachment #616614 -
        Flags: approval-mozilla-aurora- → approval-mozilla-aurora+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0636e5319324
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 13 → Firefox 17
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.