729646 - mwc-demo : Runfield will zoom in if it is in a background tab and the phone is rotated.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to runfield demo
2. switch to landscape
3. open a new tab to the mwc-demo front page
4. change orientations to portrait
4. switch to the runfield demo

expected: runfield demo is not zoomed in
actual: runfield demo is zoomed in

Note:
1. occurs on : nightly 02/22/2012 on galaxy nexus, htc desire
2. occurs on : maple 02/22/2012 on galaxy nexus, htc desire
3. changing orientations after this will continue to have runfield zoomed in.
4. Runfield remains at "Loading..." on Samsung Galaxy S II on nightly; does not seem to load at all on Maple; Server not found error?

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

scratch point 4.  I think it was something in my cache causing Runfield not to load.  Galaxy S II also exhibits this issue on Nightly and Maple.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Second scenario screenshot

A different test case:
1. sign into hahlo.com in portrait
2. hit the home button
3. rotate the phone
4. go back to fennec
5. scroll all the way down

Expected: the layers will be the same size
Actual: part of the layers resized, part of it did not; see screenshot

I believe that this might be the same underlying issue.

Comment 3

[Joe Drew (not getting mail)]

Kats, I bet this will be fixed with your rewrite.

Comment 4

[JP Rosevear [:jpr]]

Seems to happen with latest maple still

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/3) Remove some annoying logging

Didn't want to file a new bug just for this :)

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/3) Do CSS viewport resizing on background tabs

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: (3/3) Update display port on background tabs as well

Without this we have the wrong display port set after we switch to a different tab after a rotation. The wrong display port manifests as either a temporary glitch or a more permanent paint error (which goes away on panning or other user input), but both of these are undesirable.

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 605962 [details] [diff] [review]
(1/3) Remove some annoying logging

Review of attachment 605962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 10

[Chris Lord [:cwiiis]]

Comment on attachment 605964 [details] [diff] [review]
(2/3) Do CSS viewport resizing on background tabs

Review of attachment 605964 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but would like to know about the comment below.

::: mobile/android/chrome/content/browser.js
@@ +2051,5 @@
>      if (!browser)
>        return;
>  
> +    let screenW = window.outerWidth;
> +    let screenH = window.outerHeight;

Would we not still want to use gScreenWidth/Height here? They ought to always be the same, and it's probably faster to access the former(?)

Comment 11

[Chris Lord [:cwiiis]]

Comment on attachment 605965 [details] [diff] [review]
(3/3) Update display port on background tabs as well

Review of attachment 605965 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Lord [:cwiiis] from comment #10)
> 
> Would we not still want to use gScreenWidth/Height here? They ought to
> always be the same, and it's probably faster to access the former(?)

Yeah, I changed it back on landing. I think I put in the window.* as an intermediate change and forgot to clean it up.

Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/353c5afe3b2c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d51f2f3e8e8
https://hg.mozilla.org/integration/mozilla-inbound/rev/39a08a81947e

Comment 13

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/353c5afe3b2c
https://hg.mozilla.org/mozilla-central/rev/4d51f2f3e8e8
https://hg.mozilla.org/mozilla-central/rev/39a08a81947e

Comment 14

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 15.0a1 (2012-04-30)
Firefox 14.0a2 (2012-04-30)

Device: Samsung Captivate
OS: Android 2.2