729681 - Remove separate launcher icon for Firefox Sync

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #724292 +++

Now that Firefox Sync is accessible both from in-browser UI and from the Android "Settings" app, we don't really need a separate launcher (home screen) icon for it.  UX agrees; see bug 724292 comment 13 from Madhava.

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 599749 [details] [diff] [review]
patch

Review of attachment 599749 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Please make sure you have tested:

* Access to Sync setup through Fennec's home screen
* Access to the Sync settings pane through Fennec's in-app prefs
* Access to Sync setup through Settings
* Functionality of the "Pair a device" button in Settings once Sync is set up.

I will handle lifting this change to the canonical copy of this file in GitHub.

Comment 2

[Matt Brubeck (:mbrubeck)]

I successfully tested all the use cases listed in comment 1.

https://hg.mozilla.org/integration/mozilla-inbound/rev/27d927a836a2

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

we do want this kind of cleanup for release.

Comment 4

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> we do want this kind of cleanup for release.

Already landed in inbound; working fine in my personal builds.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/27d927a836a2

Comment 6

[Aaron Train [:aaronmt]]

Should this land on Aurora now to avoid any confusion with now a single Sync icon (product association?)

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 599749 [details] [diff] [review]
patch

Yup.

Comment 8

[Tony Chung [:tchung]]

Verified fix on 2012-02-24 nightly.   Sync App launcher has been self-removed after the update.  Also tested a fresh nightly install, and no sync launcher is available.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 599749 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora 12 since this is mobile only.