72969 - news:// links try to open in browser

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[Luke Morey]

I'm using the latest nightly 20010320 under Windows 2000 with SP1.

Clicking on any news: hyperlink in the browser does not launch mail-news, it
tries to open in the browser.  The location in the navigation bar changes to
news://servername:119/news.group.name

Try following any n.p.m.* link on the community/newsgroups page for example.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Confirming.  Oddly enough, if you open a mail/news window right after this, we
Do the Right Thing, that is, we fire up the Account Wizard, and add (in my case)
netscape.public.mozilla.announce to my default news server (news.mozilla.org). 
Build 2001032204.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

I think Seth might own this.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

If you have a server like news.mozilla.org already in the Folder Pane, clicking 
news://news.mozilla.org/netscape.public.mozilla.mail-news no longer tries to 
auto-subscribe you to that group, nor will it open that newsgroup up, if you're 
already subscribed to it.  We do the right thing when you don't have the server 
defined in the account manager.  

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 77951 has been marked as a duplicate of this bug. ***

Comment 5

[scottputterman]

moving to 0.9.2

Comment 6

[chris hofmann]

what are the chances of this getting fixed in the next few days...
might help us getting better feedback on the nscp beta...

Comment 7

[chris hofmann]

adding another test page
http://home.netscape.com/browsers/6/feedback/index.html
which has many such news links embedded in it.

Comment 8

[scottputterman]

reassigning to cavin

Comment 9

[(not reading, please use [e-mail] instead)]

notes to cavin:  this regressed, not sure when.

at a certain point "autosubscribe urls" (like news://host/group) would open
another 3 pane window to that group.  if you had never subscribed to a group on
"host", you'd get the 3 pane window, and an new account wizard (so you could
configure the new news account)

we may have always opened up a browser window, I can't remember off the top of
my head.  try the official NS 6.0 bits to see what's regressed.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

I'm trying the official builds now.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

6.01 does this right (or partially right?), that is, when you click a link in a
mail/news message like news://news.mozilla.org/netscape.public.mozilla.mail-news
we spawn a new 3-pane mail window, with news.mozilla.org as the server, and
n.p.m.mail-news subscribed, then we popup the Account Wizard.  We don't touch
the URL bar of the browser (as current behavior does).

Comment 12

[(not reading, please use [e-mail] instead)]

ok, I think I broke this when I cleaned up / rewrote a lot of the news code 
(during the perf landing.)

right now, news://host/group urls have the content type of "message/rfc-822" 
instead of "x-application-newsgroup".

investigating a fix now.

taking back from cavin, I think I can have something for 0.9.1

Comment 13

[(not reading, please use [e-mail] instead)]

I've got a simple patch that returns us to the 6.0 behaviour.

there are still some issues, but they can moved off to another milestone.

specifically, 

1) we still need to select the new newsgroup in the 3 pane we just opened
2) [eventually] we need to heed the pref for whether or not to open a new 3 
pane, or use existing ones.

#1 is the most interesting, and ties in heavily with some code the that 
suresh/gayatrib/prass and I were working on for loading the 3 pane to a 
selected folder for search.

I think both of these were known issues back in 6.0.

here comes the fix...

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 15

[David :Bienvenu]

rs=bienvenu

Comment 16

[Scott MacGregor]

r=mscott. 

Comment 17

[(not reading, please use [e-mail] instead)]

updating status.

thanks for the speedy reviews.

Comment 18

[(not reading, please use [e-mail] instead)]

#36662 is the outstanding bug about not selecting the newsgroup.

I'm pretty sure the other bug is in bugzilla.  it would be about fixing the 
messenger window service to heed that pref.  (we may also have to add that pref 
back to the pref UI)

Comment 19

[(not reading, please use [e-mail] instead)]

fixed.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED, clicking on a link such as
news://news.mozilla.org/netscape.public.mozilla.mail-news opens a new mail/news
window, with that server & newsgroup in the folder pane, and brings up the
account wizard, on the following platforms/builds:

Windows 2000 build 2001-05-31-04
Mac OS 9.1   build 2001-05-31-08
RedHat 7.0   build 2001-05-31-08

There are other outstanding bugs, but we are back from the regression.

Comment 21

[Luke Morey]

Is this right?

news://news.mozilla.org:119/[e-mail] (current link for the
Mozilla 1.0 manifesto under _news_ on the front page) opens a browser window,
not mail-news.

Not re-openening yet, but I'm not at all convinced by this behaviour...

Comment 22

[[e-mail] (gone - use [e-mail] instead)]

Luke, all of the comments and patches in this bug were for the format of
news://host/group.

For message-ids, that should be covered in bug 11076.