729714 - nsExceptionHandler.cpp fails to build for Android/x86

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mike Hommey [:glandium]]

In file included from /home/mh/mozilla-central/toolkit/crashreporter/nsExceptionHandler.cpp:82:
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.h:201: error: field 'context' has incomplete type
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/handler/exception_handler.h:204: error: field 'float_state' has incomplete type
In file included from /home/mh/mozilla-central/toolkit/crashreporter/nsExceptionHandler.cpp:83:
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:48: error: invalid use of incomplete type 'struct google_breakpad::user'
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:48: error: forward declaration of 'struct google_breakpad::user'
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:48: error: invalid type in declaration before ';' token
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:91: error: 'user_regs_struct' does not name a type
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:92: error: 'user_fpregs_struct' does not name a type
/home/mh/mozilla-central/toolkit/crashreporter/google-breakpad/src/client/linux/minidump_writer/linux_dumper.h:96: error: 'user_fpxregs_struct' does not name a type
/home/mh/mozilla-central/toolkit/crashreporter/nsExceptionHandler.cpp: In function 'void CrashReporter::FileIDToGUID(const char*, u_int8_t*)':
/home/mh/mozilla-central/toolkit/crashreporter/nsExceptionHandler.cpp:298: warning: comparison between signed and unsigned integer expressions

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

x86 is not blocking 1.0

Comment 2

[(not currently active) Ted Mielczarek]

This is probably some Breakpad code I wrote assuming that Android == arm.

Comment 3

[Aissen]

Is this fixed ? I just built android/x86 with the release mozconfig, and it doesn't have breakpad disabled.
I believe Ted updated breakpad on September 25th, which fixed this. See bug #791775

Comment 4

[(not currently active) Ted Mielczarek]

There were some upstream Breakpad fixes that fixed the Android/x86 case. Thanks for testing, I forgot about this bug because I never set a dependency.