730024 - Reports/List "Table" not displaying for ESR

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[[:jberkus] Josh Berkus]

Checking signature information for ESR, everything appears to work *except* that the "Table" tab is empty.  This may be legitimate, or a bug:

https://crash-stats-dev.allizom.org/report/list?range_value=7&range_unit=days&date=2012-02-19&signature=magicscanner.dll%400x173af&version=Firefox%3A10.0.2esr

Comment 1

[Lonnen :lonnen]

Checked the other signatures on c-s-d and it looks like all esr crash sigs have this problem, but non-esr does not.

Comment 2

[Lonnen :lonnen]

Also, this view is confusing because the signature summary tab has a different data source than the rest of the tabs. Don't listen to the plain text description saying that it results on the page are of the version `Firefox:10.0.2esr`. It is a lie.

The important bit is that the crashes in the 'reports' tab are not showing up in the graph or table tabs.

Comment 3

[Lonnen :lonnen]

'Reports' tab sources from the middleware, which seems to do ESR correctly.
The Graph and Table tabs come from common_model->queryFrequency, which does this (http://pastebin.mozilla.org/1491507). That mess is missing ESR crashes.

Comment 4

[Lonnen :lonnen]

Formatted the sql (http://pastebin.mozilla.org/1491522). Line 22 seems to be the problem -- ESR releases in the dev repo have build_type ESR.

Is this the expect build type, or should I be expecting 'Release' here?

Comment 5

[Lonnen :lonnen]

<strike>repo</strike>, devDB*

Comment 6

[[:jberkus] Josh Berkus]

"ESR" is the correct build_type (and release-channel).

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e1e7457ebbc085646fe8fc0dc5bd6294a054a158
Merge pull request #401 from Lonnen/730024-reports-list

Bug 730024 - add esr to report common

Comment 8

[Matt Brandt [:mbrandt]]

QA verified on dev and staging - the "Table" tab for ESR releases is no longer empty.