730025 - [traceback] Don't list incomplete apps in the upsell block

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Make sure you have a few incomplete apps associated with your account.
2. Upload another app
3. Continue to Step 4: Payments
4. In the upsell block, click the dropdown menu 

expected behavior:
Only free and completed apps are listed

actual behavior:
We list incomplete apps in the upsell block

Comment 1

[krupa raj[:krupa]]

Traceback (most recent call last):

  File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 112, in wrapper
    return f(*args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 104, in wrapper
    return f(*args, **kw)

  File "/usr/lib64/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)

  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/models.py", line 40, in skip_cache
    yield

  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 104, in wrapper
    return f(*args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/apps/addons/decorators.py", line 29, in wrapper
    return f(request, addon, *args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 29, in wrapper
    return func(request, *args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/decorators.py", line 50, in wrapper
    return fun()

  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/decorators.py", line 27, in <lambda>
    *args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/mkt/submit/decorators.py", line 19, in wrapper
    return f(request, *args, **kw)

  File "/data/www/addons-dev.allizom.org/zamboni/mkt/submit/views.py", line 158, in payments_upsell
    'amo_user': request.amo_user})

  File "/data/www/addons-dev.allizom.org/zamboni/mkt/submit/forms.py", line 102, in __init__
    kw['initial']['price'] = self.addon.premium.price

KeyError: 'initial'

Comment 2

[Andy McKay]

https://github.com/mozilla/zamboni/commit/66bbf7
https://github.com/mozilla/zamboni/commit/9ada1d

Comment 3

[krupa raj[:krupa]]

verified fixed at https://marketplace-dev.allizom.org/en-US/developers/app/seevans-underworld-adventur-9/payments