730153 - SUT agent KILL command fails to kill xpcshell

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

In bug 705192, I try to use the devicemanager kill command to clean up any xpcshell processes that may have hung. With SUT, that fails: hung xpcshell processes continue to live.

I think the issue is that the SUT agent uses getRunningAppProcesses to examine which processes are currently running and it appears to only return android application names, like org.mozilla.fennec.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

See also bug 729552

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: patch to kill non-Java processes

In this patch, if the KILL command does not find a matching application, it now continues to search for a matching process by checking the "ps" command output.

I found that I could not kill xpcshell with "su -c kill <pid>" or even "su -c kill -9 <pid>"...both failed silently. However, a simple "kill <pid>" worked just fine. I don't understand why the su commands fail. (Also, the su commands successfully kill xpcshell if executed from adb shell.) It makes sense to me that su should not be needed: xpcshell is a child process of the sutagent, so sutagent should be able to kill it without special privileges.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 601301 [details] [diff] [review]
patch to kill non-Java processes

Review of attachment 601301 [details] [diff] [review]:
-----------------------------------------------------------------

note that we will have to build an agent and deploy it in staging, then roll it out to all the tegras before tests which depend on this can land.

Comment 4

[cmtalbert]

landed m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/5bbffabdc291

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/5bbffabdc291