730273 - Hardcoded add-on's on about:home linked to wrong base URL

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

Oddly, the add-ons on about:home are linked (aAddon.homepageURL) to /mobile/, they should be linked to /android/ on AMO. I say oddly because extensions.getAddons.browseAddons is correctly valued.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Which add-ons do you see? We have a hardcoded JSON file in the APK we use if there is no JSON in the profile. The hardcoded file might need to be updated.

Comment 2

[Aaron Train [:aaronmt]]

I see the same two that have been around: Cleary/Clear Mobile History

Comment 3

[Aaron Train [:aaronmt]]

Ok, so I guess it's these

http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/recommended-addons.json?raw=1

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Ok, so I guess it's these
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/recommended-
> addons.json?raw=1

Right. That file should be updated. It has too much data in it too.

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Cleanup recommended-addons.json to only contain necessary properties

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 600426 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

I'm not sure these add-ons have been ported to Native Fennec. We should verify that first or use add-ons that have been ported.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Lucas, is anything holding this up?

Comment 8

[Lucas Rocha (:lucasr)]

(In reply to Brad Lassey [:blassey] from comment #7)
> Lucas, is anything holding this up?

I need to come up with a list of addons we know it's working with Native Fennec and update the recommended-addons.json file accordingly. Should be doing it this week.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava, Jaclyn - What current add-ons for Native Fennec would you like listed initially when a user starts up for the first time? Or should we just show nothing until we request the recommended addons from AMO?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Lucas - OK, my executive decision on this is to grad "Full Screen" by Matt and "Cloud Viewer" by me. Use those two as the hardcoded entries for now.

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Cleanup recommended-addons.json to only contain necessary properties

Comment 12

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/301109c61000

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/301109c61000

Comment 14

[Lucas Rocha (:lucasr)]

Comment on attachment 610888 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

Mobile only. Release blocker.

Comment 15

[Alex Keybl [:akeybl]]

Comment on attachment 610888 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

[Triage Comment]
Mobile only & blocking Fennec 1.0. Approved for Aurora 13.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/65c09980e4c5

Comment 17

[Cristian Nicolae (:xti)]

It seems that everything works as expected, both on Nightly and Aurora builds.
Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Firefox 14.0a2 (2012-05-22)

Device: Galaxy Nexus
OS: Android 4.0.2