Hardcoded add-on's on about:home linked to wrong base URL

VERIFIED FIXED in Firefox 13

Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: aaronmt, Assigned: lucasr)

Tracking

Trunk
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 verified, firefox15 verified, blocking-fennec1.0 +)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Oddly, the add-ons on about:home are linked (aAddon.homepageURL) to /mobile/, they should be linked to /android/ on AMO. I say oddly because extensions.getAddons.browseAddons is correctly valued.
Which add-ons do you see? We have a hardcoded JSON file in the APK we use if there is no JSON in the profile. The hardcoded file might need to be updated.
(Reporter)

Comment 2

5 years ago
I see the same two that have been around: Cleary/Clear Mobile History
(Reporter)

Comment 3

5 years ago
Ok, so I guess it's these

http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/recommended-addons.json?raw=1
Summary: Browse add-on's on about:home linked to wrong base URL → Hardcoded add-on's on about:home linked to wrong base URL
(In reply to Aaron Train [:aaronmt] from comment #3)
> Ok, so I guess it's these
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/recommended-
> addons.json?raw=1

Right. That file should be updated. It has too much data in it too.
Assignee: nobody → lucasr.at.mozilla
Keywords: fennecnative-releaseblocker
Priority: -- → P2
(Assignee)

Comment 5

5 years ago
Created attachment 600426 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties
Attachment #600426 - Flags: review?(mark.finkle)
Comment on attachment 600426 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

I'm not sure these add-ons have been ported to Native Fennec. We should verify that first or use add-ons that have been ported.
Attachment #600426 - Flags: review?(mark.finkle) → review-
blocking-fennec1.0: --- → +
Status: NEW → ASSIGNED
Lucas, is anything holding this up?
(Assignee)

Comment 8

5 years ago
(In reply to Brad Lassey [:blassey] from comment #7)
> Lucas, is anything holding this up?

I need to come up with a list of addons we know it's working with Native Fennec and update the recommended-addons.json file accordingly. Should be doing it this week.
Madhava, Jaclyn - What current add-ons for Native Fennec would you like listed initially when a user starts up for the first time? Or should we just show nothing until we request the recommended addons from AMO?
Lucas - OK, my executive decision on this is to grad "Full Screen" by Matt and "Cloud Viewer" by me. Use those two as the hardcoded entries for now.
(Assignee)

Comment 11

5 years ago
Created attachment 610888 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties
Attachment #610888 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
Attachment #600426 - Attachment is obsolete: true
Attachment #610888 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 12

5 years ago
Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/301109c61000
https://hg.mozilla.org/mozilla-central/rev/301109c61000
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Comment 14

5 years ago
Comment on attachment 610888 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

Mobile only. Release blocker.
Attachment #610888 - Flags: approval-mozilla-aurora?
Comment on attachment 610888 [details] [diff] [review]
Cleanup recommended-addons.json to only contain necessary properties

[Triage Comment]
Mobile only & blocking Fennec 1.0. Approved for Aurora 13.
Attachment #610888 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/65c09980e4c5
status-firefox13: --- → fixed
status-firefox14: --- → fixed
It seems that everything works as expected, both on Nightly and Aurora builds.
Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Firefox 14.0a2 (2012-05-22)

Device: Galaxy Nexus
OS: Android 4.0.2
Status: RESOLVED → VERIFIED
status-firefox14: fixed → verified
status-firefox15: --- → verified
You need to log in before you can comment on or make changes to this bug.