remove CSS2Properties aliases for MozOpacity and MozOutline*

RESOLVED FIXED in mozilla13

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({dev-doc-complete})

Trunk
mozilla13
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
I just noticed that in bug 413141 and bug 458588 we didn't drop the CSS2Properties aliases for the CSS aliases that we removed.

CSS2Properties aliases are also in multiple places; they're getting to be a bit of a pain to edit.

So I have:
 (1) a patch to make CSS aliases be driven by a header file (though, until bug 698072, we'll still have to edit nsIDOMCSS2Properties.idl).  This temporarily fully readds the aliases partially removed above
 (2) A patch to fully remove the aliases above.

Testing with only patch (1) and with both patches ensures that my header file approach works both with and without aliases.
(Assignee)

Comment 1

6 years ago
Created attachment 600604 [details] [diff] [review]
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove).  (, patch 1)
Attachment #600604 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Created attachment 600605 [details] [diff] [review]
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset).  (, patch 2)
Attachment #600605 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

6 years ago
Created attachment 600606 [details] [diff] [review]
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline).  (, patch 3)
Attachment #600606 - Flags: review?(mihai.sucan)
Comment on attachment 600604 [details] [diff] [review]
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove).  (, patch 1)

r=me
Attachment #600604 - Flags: review?(bzbarsky) → review+
Comment on attachment 600605 [details] [diff] [review]
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset).  (, patch 2)

r=me
Attachment #600605 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc9d929b260
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbf894da185
Keywords: dev-doc-needed
Comment on attachment 600606 [details] [diff] [review]
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline).  (, patch 3)

Thanks for the patch!
Attachment #600606 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 8

6 years ago
(In reply to Mihai Sucan [:msucan] from comment #7)
> Comment on attachment 600606 [details] [diff] [review]
> Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> outline).  (, patch 3)
> 
> Thanks for the patch!

And, to be clear:  if upstream cares about supporting versions of Firefox prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch.  It's not clear to me if they do.
https://hg.mozilla.org/mozilla-central/rev/ffc9d929b260
https://hg.mozilla.org/mozilla-central/rev/9cbf894da185
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to David Baron [:dbaron] from comment #8)
> (In reply to Mihai Sucan [:msucan] from comment #7)
> > Comment on attachment 600606 [details] [diff] [review]
> > Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> > outline).  (, patch 3)
> > 
> > Thanks for the patch!
> 
> And, to be clear:  if upstream cares about supporting versions of Firefox
> prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch. 
> It's not clear to me if they do.

Orion aims for compatibility with much newer Firefox releases. Orion 0.3 had a minimum requirement of Firefox 5. Orion 0.4 (the current release being worked on) requires Firefox 8.

Reported this bug upstream:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=372665
(Assignee)

Comment 11

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4253db247d
https://hg.mozilla.org/mozilla-central/rev/dd4253db247d
The affected interface isn't documented, so all I did was mention this change on Firefox 13 for developers.
Keywords: dev-doc-needed → dev-doc-complete

Updated

5 years ago
Depends on: 765645
You need to log in before you can comment on or make changes to this bug.