Last Comment Bug 730532 - remove CSS2Properties aliases for MozOpacity and MozOutline*
: remove CSS2Properties aliases for MozOpacity and MozOutline*
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P3 normal (vote)
: mozilla13
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on: 765645
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 19:10 PST by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2012-06-18 02:00 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove). (, patch 1) (10.61 KB, patch)
2012-02-24 19:14 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset). (, patch 2) (4.50 KB, patch)
2012-02-24 19:14 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Review
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline). (, patch 3) (3.70 KB, patch)
2012-02-24 19:23 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
mihai.sucan: review+
Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-24 19:10:53 PST
I just noticed that in bug 413141 and bug 458588 we didn't drop the CSS2Properties aliases for the CSS aliases that we removed.

CSS2Properties aliases are also in multiple places; they're getting to be a bit of a pain to edit.

So I have:
 (1) a patch to make CSS aliases be driven by a header file (though, until bug 698072, we'll still have to edit nsIDOMCSS2Properties.idl).  This temporarily fully readds the aliases partially removed above
 (2) A patch to fully remove the aliases above.

Testing with only patch (1) and with both patches ensures that my header file approach works both with and without aliases.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-24 19:14:44 PST
Created attachment 600604 [details] [diff] [review]
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove).  (, patch 1)
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-24 19:14:55 PST
Created attachment 600605 [details] [diff] [review]
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset).  (, patch 2)
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-24 19:23:27 PST
Created attachment 600606 [details] [diff] [review]
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline).  (, patch 3)
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-02-24 19:37:50 PST
Comment on attachment 600604 [details] [diff] [review]
Add a header file for CSS property aliases (and temporarily resurrect the aliases whose DOM properties we forgot to remove).  (, patch 1)

r=me
Comment 5 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-02-24 19:38:51 PST
Comment on attachment 600605 [details] [diff] [review]
Remove the CSS2Properties aliases for MozOutline* and MozOpacity for CSS properties whose CSS aliases were removed long ago (but temporarily readded in the previous changeset).  (, patch 2)

r=me
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-24 21:28:27 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc9d929b260
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbf894da185
Comment 7 Mihai Sucan [:msucan] 2012-02-25 01:22:21 PST
Comment on attachment 600606 [details] [diff] [review]
Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by outline).  (, patch 3)

Thanks for the patch!
Comment 8 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-25 10:43:39 PST
(In reply to Mihai Sucan [:msucan] from comment #7)
> Comment on attachment 600606 [details] [diff] [review]
> Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> outline).  (, patch 3)
> 
> Thanks for the patch!

And, to be clear:  if upstream cares about supporting versions of Firefox prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch.  It's not clear to me if they do.
Comment 10 Mihai Sucan [:msucan] 2012-02-27 09:57:06 PST
(In reply to David Baron [:dbaron] from comment #8)
> (In reply to Mihai Sucan [:msucan] from comment #7)
> > Comment on attachment 600606 [details] [diff] [review]
> > Fix uses of removed CSS2Properties.MozOutline DOM property (replaced by
> > outline).  (, patch 3)
> > 
> > Thanks for the patch!
> 
> And, to be clear:  if upstream cares about supporting versions of Firefox
> prior to 1.5 (i.e., prior to bug 281972), then they don't want this patch. 
> It's not clear to me if they do.

Orion aims for compatibility with much newer Firefox releases. Orion 0.3 had a minimum requirement of Firefox 5. Orion 0.4 (the current release being worked on) requires Firefox 8.

Reported this bug upstream:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=372665
Comment 11 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-29 20:50:06 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4253db247d
Comment 12 Marco Bonardo [::mak] 2012-03-01 06:31:26 PST
https://hg.mozilla.org/mozilla-central/rev/dd4253db247d
Comment 13 Eric Shepherd [:sheppy] 2012-04-29 11:27:00 PDT
The affected interface isn't documented, so all I did was mention this change on Firefox 13 for developers.

Note You need to log in before you can comment on or make changes to this bug.