Last Comment Bug 730701 - Difficult to determine active tab. Insufficient color contrast.
: Difficult to determine active tab. Insufficient color contrast.
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Windows Vista
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-26 11:03 PST by Wayne Mery (:wsmwk, NI for questions)
Modified: 2012-03-21 16:42 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screen shot of tbird, chrome, firefox tabs (68.49 KB, image/png)
2012-02-26 11:03 PST, Wayne Mery (:wsmwk, NI for questions)
no flags Details
Fix the tabs (2.50 KB, patch)
2012-02-26 13:54 PST, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Wayne Mery (:wsmwk, NI for questions) 2012-02-26 11:03:22 PST
Created attachment 600792 [details]
screen shot of tbird, chrome, firefox tabs

Difficult to determine active tab.  Insufficient color contrast.

This is on Vista using Vista Windows Classic Theme.
Thunderbird 13, default theme.
Comment 1 rsx11m 2012-02-26 13:34:45 PST
This depends on the desktop theme. It's ok on Windows 7 Aero but looks like Wayne describes it on Windows Classic and Windows 7 Basic.
Comment 2 Richard Marti (:Paenglab) 2012-02-26 13:54:07 PST
Created attachment 600813 [details] [diff] [review]
Fix the tabs

Removed the :not(:-moz-lwtheme) rules and moved the properties to the right positions to work better also under classic.
Comment 3 Blake Winton (:bwinton) (:☕️) 2012-03-21 11:40:20 PDT
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

After a giant amount of work getting my Windows build, uh, building, I've finally taken a look at the patch.

It seems to fix the problem, and doesn't look horrible, so ui-r=me.  ;)

>+++ b/mail/themes/qute/mail/tabmail-aero.css

So, given that the problem only exists in classic mode, I'm not sure why you're changing tabmail-aero.css.
(I've also looked through the various Windows themes, and can't see the difference.)

Uh, but I do see the difference in classic mode, and there aren't any changes to tabmail.css, so now I'm _really_ confused.

If you can explain that (and I'm happy with the explanation), then I'll change to an r+, but for now, I've got to say r-.

Thanks,
Blake.
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-03-21 11:40:58 PDT
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

(No, I actually meant "r-".)
Comment 5 Richard Marti (:Paenglab) 2012-03-21 12:48:46 PDT
Under XP everything is okay and here the file tabmail.css is used. Under Vista/Win7 only the file tabmail-aero.css is used, also in classic mode. Because of this I had to change the wrong rules only in tabmail-aero.css
Comment 6 Blake Winton (:bwinton) (:☕️) 2012-03-21 12:50:35 PDT
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

Okay, that makes sense.  r=me!

Thanks,
Blake.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-03-21 16:42:45 PDT
http://hg.mozilla.org/comm-central/rev/4a2284b77786

Note You need to log in before you can comment on or make changes to this bug.