Difficult to determine active tab. Insufficient color contrast.

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wsmwk, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
x86
Windows Vista
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 600792 [details]
screen shot of tbird, chrome, firefox tabs

Difficult to determine active tab.  Insufficient color contrast.

This is on Vista using Vista Windows Classic Theme.
Thunderbird 13, default theme.

Comment 1

5 years ago
This depends on the desktop theme. It's ok on Windows 7 Aero but looks like Wayne describes it on Windows Classic and Windows 7 Basic.
(Assignee)

Comment 2

5 years ago
Created attachment 600813 [details] [diff] [review]
Fix the tabs

Removed the :not(:-moz-lwtheme) rules and moved the properties to the right positions to work better also under classic.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #600813 - Flags: ui-review?(bwinton)
Attachment #600813 - Flags: review?(bwinton)
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

After a giant amount of work getting my Windows build, uh, building, I've finally taken a look at the patch.

It seems to fix the problem, and doesn't look horrible, so ui-r=me.  ;)

>+++ b/mail/themes/qute/mail/tabmail-aero.css

So, given that the problem only exists in classic mode, I'm not sure why you're changing tabmail-aero.css.
(I've also looked through the various Windows themes, and can't see the difference.)

Uh, but I do see the difference in classic mode, and there aren't any changes to tabmail.css, so now I'm _really_ confused.

If you can explain that (and I'm happy with the explanation), then I'll change to an r+, but for now, I've got to say r-.

Thanks,
Blake.
Attachment #600813 - Flags: ui-review?(bwinton)
Attachment #600813 - Flags: ui-review+
Attachment #600813 - Flags: review?(bwinton)
Attachment #600813 - Flags: review+
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

(No, I actually meant "r-".)
Attachment #600813 - Flags: review+ → review-
(Assignee)

Comment 5

5 years ago
Under XP everything is okay and here the file tabmail.css is used. Under Vista/Win7 only the file tabmail-aero.css is used, also in classic mode. Because of this I had to change the wrong rules only in tabmail-aero.css
Comment on attachment 600813 [details] [diff] [review]
Fix the tabs

Okay, that makes sense.  r=me!

Thanks,
Blake.
Attachment #600813 - Flags: review- → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/4a2284b77786
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.