The default bug view has changed. See this FAQ.

kumascript: Changes to Kuma wiki document view to use Kumascript service

RESOLVED FIXED in 2.4

Status

Mozilla Developer Network
Editing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lorchard, Assigned: lorchard)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Details

(Whiteboard: u=developer c=wiki p=3 2.4.5)

(Assignee)

Description

5 years ago
Kuma, on the Django side, needs modifications to use the node.js kumascript service on document viewing and previewing.

This is what I *think* needs doing in wiki.views.document():

* The code that handles redirects and translation stays the same.
* Leave the code path handling the ?raw option alone.
* If no ?raw parameter: Perform an HTTP GET to the kumascript service to get document HTML, rather than access doc.html directly

The kumascript service should, in turn, request the doc source with ?raw and respond with macros evaluated. On the Django side, that content should still be processed for sections and editing links, etc
(Assignee)

Updated

5 years ago
Blocks: 659364
(Assignee)

Updated

5 years ago
Blocks: 730714
(Assignee)

Updated

5 years ago
Depends on: 730706
(Assignee)

Comment 1

5 years ago
Going ahead and adding this to 2.4.5 with 3 pts. I'm already underway with this and some ancillary tasks it brought up:

https://github.com/lmorchard/kuma/commits/bug-730704-kumascript-integration
Whiteboard: u=developer c=wiki p=3 2.4.5
Target Milestone: --- → 2.4
(Assignee)

Updated

5 years ago
Assignee: nobody → lorchard

Comment 2

5 years ago
Commits pushed to mdn at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/238e14a4daec574cca4799f1f0ce235057fa6c39
bug 730704: Changes to kuma to use kumascript service

* Document view performs a request to the kumascript service to evaluate
  macros before rendering response

* Tweak to CKEditor setup, skips setting it up on Template:* pages in
  advance of more work for bug 731651

* Tests for kumascript usage in document view

* Constance config setting to enforce kumascript request timeout (or to
  disable entirely, which is the default)

* Tweaks to document view and model to support HTTP ETag and
  Last-Modified headers, in advance of caching support for
  bug 730714 and bug 730715

* Add kumascript service as a submodule

* Add node.js and kumascript config to vagrant/puppet

* Added tmux to vagrant install, because it's very handy

* Updates to .gitignore

* Bugfix to 404 on js/libs/jqueryui-min.js

https://github.com/mozilla/kuma/commit/58ea14c449f03dd20a93975f5c32bbb157616b84
bug 730704: advise using forked runserver in MOTD, kumascript update

https://github.com/mozilla/kuma/commit/a344bf0a1cb783661d479aec71249f16f2a564ec
Merge pull request #126 from lmorchard/bug-730704-kumascript-integration

Bug 730704 kumascript integration
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on bug 730705 for QA. Let's leave this resolved and get it onto stage9 during 2.5 for QA.
Depends on: 730705
Version: MDN → unspecified
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
You need to log in before you can comment on or make changes to this bug.