Closed Bug 730795 Opened 14 years ago Closed 10 years ago

XForms for Gecko 7

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: imphil, Assigned: imphil)

Details

Attachments

(2 files)

Attached patch patch v1 — — Splinter Review
Fixes required for Gecko 7. This includes the following bugs: * Bug 658906 - Remove nsIDOMNSDocument * Bug 659053 - Remove nsIDOM3Node This patch also removes nsIDOMNSFeatureFactory, which was added in bug 279057 and made the implementation of hasFeature (http://www.w3.org/TR/xforms/#expr-hasfeature) possible. This is now gone and I'm not convinced that writing a toolkit patch is worth the effort. * Bug 658363 - MOVE DEFINES FOR DOUBLE CONSTANTS OUT OF XSLT This bug unfortunately moves the macros into nsContentUtils.h which we cannot include since it uses the internal string types. We copied the macros into nsXFormsUtils.h instead.
Attachment #600885 - Flags: review?(bugs)
patch for schema-validation (only merged nsIDOM3Node with nsIDOMNode)
Attachment #600888 - Flags: review?(bugs)
Comment on attachment 600885 [details] [diff] [review] patch v1 > nsCOMPtr<nsIContent> content(do_QueryInterface(mElement)); >- *aStateVal = (content && (content->IntrinsicState().HasState(aState))); >+ *aStateVal = (content && (content->AsElement()->State().HasState(aState))); this compiles? Interesting :) I thought Element is very internal thing, but apparently not too internal.
Attachment #600885 - Flags: review?(bugs) → review+
Attachment #600888 - Flags: review?(bugs) → review+
Comment on attachment 600888 [details] [diff] [review] patch for schema-validation Review of attachment 600888 [details] [diff] [review]: ----------------------------------------------------------------- ::: src/nsSchemaLoader.cpp @@ +1105,5 @@ > else { > aLocalName.Assign(aQualifiedName); > } > > + nsCOMPtr<nsIDOMNode> node(do_QueryInterface(aContext)); No need for the QI @@ +3414,5 @@ > nsAutoString schemaTypePrefix; > schemaTypePrefix.Assign(Substring(qName.get(), colon)); > aTypeName.Assign(Substring(colon + 1, end)); > > + nsCOMPtr<nsIDOMNode> domNode = do_QueryInterface(aElement); And here ::: src/nsSchemaValidator.cpp @@ +260,5 @@ > > if (simpleType) { > // get the nodevalue using DOM 3's textContent > nsAutoString nodeValue; > + nsCOMPtr<nsIDOMNode> domNode = do_QueryInterface(aElement); And here @@ +3892,5 @@ > rv = aSchemaComplexType->GetSimpleBaseType(getter_AddRefs(simpleBaseType)); > NS_ENSURE_SUCCESS(rv, rv); > > nsAutoString nodeValue; > + nsCOMPtr<nsIDOMNode> domNode = do_QueryInterface(aNode); And here @@ +4364,5 @@ > schemaTypePrefix.Assign(Substring(qName.get(), colon)); > schemaType.Assign(Substring(colon + 1, end)); > > // get the namespace url from the prefix > + nsCOMPtr<nsIDOMNode> domNode = do_QueryInterface(aNode); And here
RIP xforms
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: