730826 - Mozilla default icons are not available anymore in marketplace-dev when editing an app.

Status: VERIFIED FIXED

Description

[Victor Carciu]

Created attachment 600915 [details]
Screenshot.

Prerequisites:
Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0

Steps to reproduce:
1.Go to https://marketplace-dev.allizom.org/en-US/developers/ and login.
2.Select My Submissions link (https://marketplace-dev.allizom.org/en-US/developers/submissions)
3.Open any owned app and click the Edit button in order to change app icon from Images section

Expected results:
A list of default icons provided by mozilla is displayed together with "Upload custom icon" button

Actual results:
The list with default icons is missing and only one icon (Puzzle) is displayed as default icon. Also, the puzzle icon is cannot be added (icon not available after selecting it and saving the changes)

Please see the attached screenshot for this bug.

Comment 1

[Wil Clouser [:clouserw]]

Did we say there would be no default app icons or am I misremembering?

Comment 2

[Victor Carciu]

I thought that the default apps icons are missing only during submission process, not when editing the app.

Also, if we will not have default icons for apps, please let me know how to consider the unusable "puzzle" icon .

Comment 3

[Christopher Van Wiemeersch [:cvan]]

I changed the ADDON_ICONS_DEFAULT_URL and ADDON_ICONS_DEFAULT_PATH for Marketplace, causing the other default icons to not show up. Either way, we agreed that these icons won't show up for Marketplace - in any place. We decided to leave it in for management pages because it was easier to keep them than remove them. But they obviously need to be removed now.

Comment 4

[Potch [:potch]]

steal'd!

Comment 5

[Potch [:potch]]

> Ran 442 tests in 267.261s
> 
> OK (SKIP=9)

https://github.com/mozilla/zamboni/commit/414e2bb

Comment 6

[Victor Carciu]

Verified as fixed.

Comment 7

[Victor Carciu]

Created attachment 601262 [details]
Postfix Screenshot.