Closed Bug 730891 Opened 8 years ago Closed 8 years ago
Event` fails because `Storage Event` is not a constructor
In the web console: [10:46:46.702] new StorageEvent() [10:46:46.706] TypeError: StorageEvent is not a constructor
I changed dictionary_helper_gen.py so that nsCOMPtr's aren't initialized to nsnull (they do that implicitly). Initializing nsnull would have required to #include more stuff. StorageEvent missed also nsIDOMNSEvent, so I added DOM_CLASSINFO_EVENT_MAP_ENTRIES Can't use NS_DEFINE_EVENT_CTOR macro, since nsDOMStorageEvent doesn't have NS_New*, and I didn't see any reason to add such. So, I wrote NS_DOMStorageEventCtor manually. https://tbpl.mozilla.org/?tree=Try&rev=881de3bc4cd8
Comment on attachment 601016 [details] [diff] [review] patch Bah, OSX doesn't like the patch.
Ok, had to make sure ctor/dtor aren't inline so that I don't need to #include everything when using nsCOMPtr<> in header. The python code is ugly, but doesn't matter :) https://tbpl.mozilla.org/?tree=Try&rev=769b11f135f7
Comment on attachment 601082 [details] [diff] [review] patch r=me, but you should get khuey to review the dictionary_helper_gen.py changes.
Attachment #601082 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.