736058 - ringmark's Web Storage test fails

Status: RESOLVED FIXED

Description

[alex_mayorga]

Web Storage test at http://rng.io/ is failing.

Initially reported at http://forums.mozillazine.org/viewtopic.php?p=11821601#p11821601

Previously it was fine.

Regression window:
Stop Ring 1 Complete (301 tests):
http://hg.mozilla.org/mozilla-central/rev/75b24396b0ce
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120308 Firefox/13.0a1 ID:20120308063137

Stop Testing: Web Storage...:
Error: Permission denied for <http://rng.io> to create wrapper for object of class UnnamedClass
Source file: http://rng.io/dist/ringmark.min.js
Line: 3
http://hg.mozilla.org/mozilla-central/rev/08809a43e082
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120308 Firefox/13.0a1 ID:20120308133632

Puslog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=75b24396b0ce&tochange=08809a43e082

Triggered by:
08809a43e082 Olli Pettay — Bug 730891, event ctor for StorageEvent, r=sicking,kyle

Comment 1

[Olli Pettay [:smaug]]

Created attachment 606202 [details] [diff] [review]
patch

Looks like the test wants to create an event in an old way, yet it 
tests the typeof window.StorageEvent.

Comment 2

[Olli Pettay [:smaug]]

(I'll add some test too)

Comment 3

[Olli Pettay [:smaug]]

Created attachment 606204 [details] [diff] [review]
patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 606204 [details] [diff] [review]
patch

Review of attachment 606204 [details] [diff] [review]:
-----------------------------------------------------------------

I'd really prefer to get the spec changed to not require this behavior. .createEvent is a very silly API.

r=me if you really prefer to do this though.

Comment 5

[alex_mayorga]

(In reply to Olli Pettay [:smaug] from comment #1)
> Looks like the test wants to create an event in an old way, yet it 
> tests the typeof window.StorageEvent.

If this is bad for the web at large, maybe is worth trying to contact the creators of the test to fix it.

No many contact details at http://rng.io/about/ though...

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 606204 [details] [diff] [review]
patch

I think we should land the patch, and if spec changes, remove support
for createEvent.
also, we should land this to Aurora too. I don't want to break pages too often.

Comment 7

[Olli Pettay [:smaug]]

https://hg.mozilla.org/mozilla-central/rev/58a2cd0203ee

Comment 8

[Alex Keybl [:akeybl]]

(In reply to Olli Pettay [:smaug] from comment #6)
> Comment on attachment 606204 [details] [diff] [review]
> patch
> 
> I think we should land the patch, and if spec changes, remove support
> for createEvent.
> also, we should land this to Aurora too. I don't want to break pages too
> often.

Would you mind addressing the risk for this nomination?

Comment 9

[Olli Pettay [:smaug]]

Very low risk. We just enable creating storage events using document.createEvent()

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 606204 [details] [diff] [review]
patch

[Triage Comment]
Given the low risk evaluation, approved for Aurora 12.

Comment 11

[Olli Pettay [:smaug]]

Commit message: Bug 736058, support createEvent('StorageEvent'), r=sicking

Comment 12

[Olli Pettay [:smaug]]

So, checkin-needed for aurora.

Comment 13

[Olli Pettay [:smaug]]

Created attachment 608420 [details] [diff] [review]
aurora

Comment 14

[Olli Pettay [:smaug]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f9f77313b59e

Comment 15

[Simona B [:simonab ]]

Verified on Firefox 13 beta 3 that the test from: http://rng.io/ passes and that no error like the one from the Description is thrown.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6:
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0