Bug 722352 and bug 724116 made changes to the Google search plugin that need to propagate to all locales. google-jp.xml (x2) needs to be updated to reflect the changes. See https://hg.mozilla.org/mozilla-central/file/tip/browser/locales/en-US/searchplugins/google.xml for the latest en-US version.
Shall I make a patch or is someone else going to take this?
Matthew, if you could do a patch, that'd be surely appreciated.
6 years ago
Created attachment 602189 [details] [diff] [review] v.1 Include channel and client changes while preserving variances from en-US (m-a + m-c)) This should apply to all 4 repos (ja/ja-JP-mac + m-c/m-a). Does anyone know why "qu" rather than "q" is used for the search term query parameter for suggestions? I don't don't know where to find the commit history prior to HG usage to investigate for myself.
Hard to find, but the way to get to pre-Hg blame is: http://mxr.mozilla.org/l10n-central/source/ja/browser/searchplugins/google-jp.xml -> http://mxr.mozilla.org/l10n/source/ja/browser/searchplugins/google-jp.xml I.e. remove "central" from the MXR URL, then use the "CVS Log"/"CVS Blame" links. Since this file was added on the MOZILLA_1_8_BRANCH, you need to take a further step and check the revision log there, by changing "HEAD" to "MOZILLA_1_8_BRANCH" in the log URL: http://bonsai-l10n.mozilla.org/cvslog.cgi?file=l10n/ja/browser/searchplugins/google-jp.xml&rev=MOZILLA_1_8_BRANCH&mark=1.2 Unfortunately none of that is any more enlightening. I imagine "qu" may have meant "UTF-8 encoded input" vs. whatever other encoding default "q" assumes, since the suggest URL doesn't contain the "ie" (input encoding) parameter. I can't test this right now because as far as I can tell the Japanese suggestions URL is broken (I get a 400 Bad Request response when trying to load it).
Review ping. (In reply to Gavin Sharp (use email@example.com for email) from comment #4) Thanks > I can't test this right now because as far as I > can tell the Japanese suggestions URL is broken (I get a 400 Bad Request > response when trying to load it). http://suggestqueries.google.com/complete/search?output=firefox&client=firefox&hl=ja&qu=Gavin WFM
Comment on attachment 602189 [details] [diff] [review] v.1 Include channel and client changes while preserving variances from en-US (m-a + m-c)) Review of attachment 602189 [details] [diff] [review]: ----------------------------------------------------------------- Getting my review out of the way, though the real review should come from the Japanese team. That doesn't necessarily have to be dynamis, if someone from the Japanese team can jump in, that'd be great.
(In reply to Matthew N. [:MattN] from comment #5) > http://suggestqueries.google.com/complete/ > search?output=firefox&client=firefox&hl=ja&qu=Gavin WFM Yeah, it works in Firefox. I can't get it to work in curl/wget for some reason, even with the same UA string/headers. Anyhow, I can't seem to observe any differences between q/qu.
Masahiko, can you do the review and landing for us here?
Reviewed. The patched search plugin works with Japanese search words. We haven't updated m-c repos. So, I'll landing this to aurora (13.0) and beta (12.0).
Done. beta (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/af5fcc73cadc http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/de16b68fb1a4 aurora (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/513a6fa53545 http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/908cba2204ba
Marking FIXED, thanks. Please remember to sign-off when you tested this on the aurora nightlies.
5 years ago