731241 - App counter is not refreshed after deleting an app in marketplace-dev

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Description

[Victor Carciu]

Prerequisites:
Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0

Steps to reproduce:
1.Go to https://marketplace-dev.allizom.org/en-US/developers/ and login.
2.Delete an app 

Expected results:
App counter is updated accordingly

Actual Results:
App counter is not updated.

NOTE:The consequence of this issue is that the user can access a page where the apps were already deleted. In this case , a message saying that "You haven't yet submitted an app to the Mozilla Marketplace." is displayed. Please see screencast for this issue below:
http://screencast.com/t/TuuxChPOZ2

Comment 1

[Rob Hudson [:robhudson]]

This is a result of caching. The first time the dashboard is loaded it does a count query which is cached for 60 seconds (according to settings.CACHE_COUNT_TIMEOUT). After a delete, if you hit this page again within the 60 seconds the count will be off by one. The count is passed to the paginator which produces an extra page, which is especially unpleasant when the count is 1 more than the page limit.

We can't invalidate counts easily, but there are options I think...

1. Alter the wording to be more correct, and be smarter about if they have *any* apps vs no apps.

2. Detect when the cached count is 1 more than the page limit and force a new query to get a fresh count to pass to the paginator.

3. Set a "force-recount" cookie with a 60 sec expiry when we delete apps, that we detect and use here. (Similar to db write pinning)

Comment 2

[Wil Clouser [:clouserw]]

Changing wording sounds the easiest! :)

Comment 3

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/