Closed Bug 731316 Opened 9 years ago Closed 9 years ago

Add -Wno-unknown-warning-option to default Clang flags

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla13

People

(Reporter: gps, Assigned: espindola)

References

Details

Attachments

(1 file)

I'd like to propose adding -Wno-unknown-warning-option to the default Clang compiler flags. If we don't do this, when we add new warning flags to support latest (possibly unreleased Clang) like bug 727145, users on older/released versions see diagnostics for the unsupported warnings. This is annoying and is arguably useless build noise.
Assignee: nobody → respindola
I was in the middle of cleaning up my build anyway, here's what I used to silence the warnings
Attachment #601395 - Flags: feedback?(respindola)
\o/ That is so much cleaner than configure.in. I wish I knew about that when I did bug 717713. I don't suppose it is too much to ask to have that flag ported as part of this bug...
Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

We should one day add a generic "check if this option exists" macro, but this is an improvement. Thanks.
Attachment #601395 - Flags: feedback?(respindola) → feedback+
Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

Rafael, if you're OK with this please set checkin-needed (or check it in yourself, if you want)
Attachment #601395 - Flags: review?(respindola)
Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

I will check it in.
Attachment #601395 - Flags: review?(respindola) → review+
https://hg.mozilla.org/mozilla-central/rev/51c165e93859
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.