731316 - Add -Wno-unknown-warning-option to default Clang flags

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

I'd like to propose adding -Wno-unknown-warning-option to the default Clang compiler flags. If we don't do this, when we add new warning flags to support latest (possibly unreleased Clang) like bug 727145, users on older/released versions see diagnostics for the unsupported warnings. This is annoying and is arguably useless build noise.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Add -Wno-unknown-warning-option

I was in the middle of cleaning up my build anyway, here's what I used to silence the warnings

Comment 2

[Gregory Szorc [:gps]]

\o/ That is so much cleaner than configure.in. I wish I knew about that when I did bug 717713. I don't suppose it is too much to ask to have that flag ported as part of this bug...

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

We should one day add a generic "check if this option exists" macro, but this is an improvement. Thanks.

Comment 4

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

Rafael, if you're OK with this please set checkin-needed (or check it in yourself, if you want)

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 601395 [details] [diff] [review]
Add -Wno-unknown-warning-option

I will check it in.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=51c165e93859

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/51c165e93859