731332 - importScripts_worker.js should not try to access "http://flippety*"

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Serge Gautherie (:sgautherie)]

Let's replace this by a known domain, fwiw.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

The point is that it should fail though.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) importScripts_worker.js: Do not try to access the network [Checked in: Comments 5 and 9]

[Mozilla/5.0 (Windows NT 5.0; rv:12.0a1) Gecko/20120126 Firefox/12.0a1 SeaMonkey/2.9a1] (custom debug build for Windows 2000)

I can't reproduce bug 731266 by running test_importScripts.html alone, but anyway...

Comment 3

[[e-mail]]

(In reply to ben turner from comment #1)
> The point is that it should fail though.
Sure, but not because the domain happens not to be registered... now I could have screwed with philor's mind by registering the domain and creating a page that randomly fails or succeeds, but the point is you should fix the test.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 601378 [details] [diff] [review]
(Av1) importScripts_worker.js: Do not try to access the network
[Checked in: Comments 5 and 9]

Ping for review.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 601378 [details] [diff] [review]
(Av1) importScripts_worker.js: Do not try to access the network
[Checked in: Comments 5 and 9]

https://hg.mozilla.org/mozilla-central/rev/26342266f309


[Approval Request Comment]
Regression caused by (bug #): Bug 450449.
User impact if declined: None, but related to bug 626999 (and might be involved in bug 731266)...
Testing completed (on m-c, etc.): this comment.
Risk to taking this patch (and alternatives if risky): None, test only.
String changes made by this patch: None.

Comment 6

[(not currently active) Ted Mielczarek]

I wouldn't bother requesting approval for simple test fixes like this, just land it on Aurora. (If anyone complains, you can tell them I said it was ok.)

Comment 7

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9907016&tree=Firefox
Rev3 Fedora 12 mozilla-central opt test mochitests-3/5 on 2012-03-08 04:42:21 PST for push 0337458a08ba
{
10735 INFO TEST-START | /tests/dom/workers/test/test_importScripts.html
10736 INFO TEST-PASS | /tests/dom/workers/test/test_importScripts.html | worker correctly stopped
10737 INFO TEST-END | /tests/dom/workers/test/test_importScripts.html | finished in 241ms
}

V.Fixed

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Ted Mielczarek [:ted] (away until ~March 7) from comment #6)
> I wouldn't bother requesting approval for simple test fixes like this, just
> land it on Aurora. (If anyone complains, you can tell them I said it was ok.)

Thanks for this one :-)

But I will keep requesting because of past contradictory experiences...
(For example, test-only fixes are not approved for beta until next cycle...)

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 601378 [details] [diff] [review]
(Av1) importScripts_worker.js: Do not try to access the network
[Checked in: Comments 5 and 9]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e62e4dc101c2

Comment 10

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=e62e4dc101c2
succeeded.

firefox12: verified.