Need to change how FilePicker is invoked so it can be overridden by embedding clients. Some details below, more at URL above; danm will be happy to help and answer questions. UI Posed by Gecko (Up Calls) ============================ These are calls to window.open, in one form or another, which are relevant to embedding. They're split into calls and callers, where a call is considered to be a base-level call to window.open which should be API-ized like we're discussing, and a caller is something which currently uses window.open but should use one of these new APIs when they're created. I've tried to categorize these sensibly... Each category implies a UI-posing component with methods for each item marked "CALL" in that category. Items marked "CALLER" in a given category may imply a new method in that component (eg. the print dialog stuff), or may just be a caller of some other extant method in a different component (eg. the uri loader opening a new window). Filepicker: CALL: /xpfe/components/filepicker/src/nsFilePicker.js#177 chrome://global/content/filepicker.xul
Adding mozilla0.9 keyword, dependency
Apologies for all the bug spam. For the detailed overview of this task, see danm's document: http://www.mozilla.org/xpfe/embedding-dialogs.html See my first cut at a component-wise categorization: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=27972 And if you want to laugh, see also my brainless incomplete IDL for these components: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=28175 dr
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9
Brian points out that the window.open in nsFilePicker.js is an implementation detail of the default Mozilla filepicker component. The filepicker component itself already meets the embedding spec: it's a separate component with a well- defined interface; it basically runs a dialog and returns a result to the caller; and all callers go through the component interface, rather than opening the window directly. Cool. Done.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → WORKSFORME
verified, invalids, and dups, oh my
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.